chore(deps)(deps): update hmac requirement from 0.12 to 0.13 - #57
Closed
dependabot[bot] wants to merge 1 commit into
Closed
chore(deps)(deps): update hmac requirement from 0.12 to 0.13#57dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
mmacedoeu
added a commit
that referenced
this pull request
Jul 17, 2026
Unblocks 6+ Dependabot cargo PRs (#57 #58 #59 #60 #62 #65) stuck on 'build-test (20, 3.11, stable)' due to libdbus-sys build.rs panic. octo-cable -> bluer -> dbus -> libdbus-sys chain needs pkg-config and libdbus-1-dev headers. ci.yml + coverage.yml already install these; quota-router.yml lacked the install. Dependabot cargo lockfile bumps invalidate the cache, exposing the gap. Same install line as ci.yml + coverage.yml for parity. Both jobs (test, clippy-stable) get the step.
Contributor
|
@dependabot rebase |
dependabot
Bot
force-pushed
the
dependabot/cargo/next/hmac-0.13
branch
from
July 17, 2026 23:58
199f988 to
dd2ea23
Compare
Updates the requirements on [hmac](https://github.com/RustCrypto/MACs) to permit the latest version. - [Commits](RustCrypto/MACs@hmac-v0.12.0...hmac-v0.13.0) --- updated-dependencies: - dependency-name: hmac dependency-version: 0.13.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/next/hmac-0.13
branch
from
July 18, 2026 00:40
dd2ea23 to
4082c87
Compare
mmacedoeu
added a commit
that referenced
this pull request
Jul 18, 2026
…ect hmac dep The 'hmac' crate (0.12) is incompatible with the current dep tree: bumps to hmac 0.13 (Dependabot PR #57) transitively require digest 0.11, but sha2 0.10 (latest) only impls digest 0.10. Result: Hmac<Sha256> from hmac 0.13 fails to satisfy KeyInit because its underlying CoreProxy type lives in the wrong digest version. The Rust CI matrix doesn't catch this because it runs on default features; --all-features does. Drop the direct 'hmac' dep and route every HMAC-SHA256 call through the existing 'hmac-sha256' 1.1 crate. hmac-sha256 has a self-contained no-deps HMAC-SHA256 implementation, so: - eliminates the second digest-version dep split - closes the path for Dependabot to re-open a broken hmac bump - trims 3 files, ~16 lines, ~3 transitive crates (digest, crypto-common, subtle, generic-array, block-buffer) from the workspace - AWS SigV4 signing + webhook signing semantics unchanged (verified via hmac-sha256's documented HMAC::mac(input, key) ≡ Hmac::new_from_slice(key).chain_update(input).finalize()) Migrations: - secret_manager.rs hmac_sha256 helper: one-line collapse onto hmac_sha256::HMAC::mac (one-shot; SigV4 step inputs are known in advance) - callbacks/webhook.rs sign_payload: drop Mac/KeyInit/Sha256 imports, use hmac_sha256::HMAC::mac directly cargo build (default + --features full) and cargo clippy --features full --all-targets -- -D warnings both pass. Blocks PR #57 (hmac 0.12->0.13) until sha2 0.11 ships; PR can be auto-rebased by Dependabot at that point without further code changes.
Contributor
|
Closed in favor of upstream removal. Direct 'hmac' dep was removed in 905d202; quota-router-core now routes Dependabot will re-open once sha2 0.11 ships (digest 0.11 support |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
mmacedoeu
added a commit
that referenced
this pull request
Jul 18, 2026
13 Dependabot PRs reviewed for impact + feasibility. 6 merged (#54 #55 #56 #61 #64 #66), 7 closed (#57 #58 #59 #60 #62 #63 #65). Analysis covers each PR's CI status, dep ownership, bump rationale, breaking-change audit, merge sequencing, and infra fixes landed (libdbus install + hmac-sha256 + std lock + stoolap parser catch-all).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on hmac to permit the latest version.
Commits
0236c8ehmac v0.13.0 (#263)b895e50Migrate tests to the new blobby format (#264)3d1440bWorkspace-level lint configuration (#261)11d4f36hmac: use release versions ofdev-dependencies(#260)c40b82bhmac: bumpsha2dev-dependency to v0.11 (#259)1fa0781Cut rc.5 prereleases (#258)a008265hmac v0.13.0-rc.6 (#256)da485cdUse(Reset)MacTraits(#254)2c51e3bhmac: deriveCloneinstead of relying on(Reset)MacTraits(#253)669d805RelaxClonebounds (#250)