Remove deprecated notify-fail flag in hyprpm - #7
Conversation
The `--notify-fail` / `-nn` flag was deprecated in version 0.53.0 and scheduled for removal in >0.56.0. This commit removes the `if` branch that parsed this flag in `hyprpm/src/main.cpp`. It also adds `include(FindPkgConfig)` to `hyprpm/CMakeLists.txt` to fix build warnings/errors related to unknown CMake commands. Co-authored-by: CosmicDorito-25 <144450574+CosmicDorito-25@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR removes the deprecated
--notify-fail(and its short version-nn) flag fromhyprpm. As noted in the comments, it was deprecated since version v0.53.0 and scheduled for removal.Additionally, added
include(FindPkgConfig)tohyprpm/CMakeLists.txtto correctly resolvepkg_check_moduleswhen buildinghyprpmvia standard CMake.PR created automatically by Jules for task 357444126583370148 started by @CosmicDorito-25