⚡ perf(layershell): Optimize std::string parameter passing by reference - #5
⚡ perf(layershell): Optimize std::string parameter passing by reference#5CipherCereal wants to merge 1 commit into
Conversation
Changes `std::string namespace_` to `const std::string& namespace_` in `CLayerShellProtocol::onGetLayerSurface` to prevent unnecessary heap allocations during function calls, improving performance. Co-authored-by: CosmicDorito-25 <144450574+CosmicDorito-25@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Updated
CLayerShellProtocol::onGetLayerSurface(both declaration inLayerShell.hppand definition inLayerShell.cpp) to acceptnamespace_as aconst std::string&instead of passing it by value (std::string).🎯 Why:
Passing a
std::stringby value forces a heap allocation if the string length exceeds the small string optimization buffer (SSO). By passing aconstreference, we eliminate this heap allocation when the function is invoked, saving unnecessary CPU and memory overhead during layer surface allocation.📊 Measured Improvement:
While a formal microbenchmark could not be cleanly measured within the sandboxed environment due to system dependencies (
aquamarine), this is a standard, fundamental C++ optimization. Avoiding deep copies on object construction is universally faster (reducing allocation overhead from O(N) to O(1)) and provides an incremental baseline performance gain that accumulates over many Wayland interactions. No regressions or functional changes are introduced asnamespace_is used strictly as a read-only parameter here before passing into object constructors.PR created automatically by Jules for task 17257361909917465648 started by @CosmicDorito-25