Skip to content

Keep identities out of release text, and make a test enforce it - #92

Merged
Cipher208 merged 1 commit into
masterfrom
fix/release-body-must-not-quote-identities
Oct 8, 2026
Merged

Cipher208 merged 1 commit into
masterfrom
fix/release-body-must-not-quote-identities

Conversation

@Cipher208

Copy link
Copy Markdown
Owner

Follow-up to #91. Fixing the workflow that leaked turned out not to be enough — the same
leak came back three times inside the same change
:

  1. the CHANGELOG entry explaining the fix quoted the identity it was removing;
  2. the release.yml comment did the same, in a second file;
  3. and when this guard was first written, its CHANGELOG sentence quoted the assertion
    output
    , putting the name back a third time.

All three were caught by reading carefully, and reading carefully is what had already
failed. So the rule is a test now.

The guard

tests/test_release_hygiene.py extracts every released section from CHANGELOG.md
using the same regex release.yml does, and checks each against the anonymizer's own
dictionary — privacy._ru_personas(). Reading the list from the feature that hides these
names means the guard cannot drift from what it protects.

Verified red, not asserted green: restoring the identity fails with
assert not {'Murat': ['Murat']}. It caught the third occurrence itself.

Also here

  • tests/test_primitives.py carried an owner name in a routing fixture. Checked that the
    route does not depend on it — any name, including a nonsense one, yields "user" — so
    the assertion is unchanged in meaning with the name removed.
  • The workflow comment and the CHANGELOG entry now describe the leak without
    reproducing it
    .

What this deliberately does not do

The identity list itself is untouched. config.yaml rag.ru_personas,
rag/synonyms.py and the privacy tests are the feature that hides these names;
deleting them would remove the anonymizer. That remains the ruling from #89 and stands.

A separate tree-wide sweep is still open — 21 occurrences in 6 files, none in the
release path
— and is reported rather than bundled here:

file identity honest read
autohooks/context.py, autohooks/examples/cowagent.yaml, docs/hooks/autohooks-platforms.md Eli persona named as spec author / platform label
tests/test_lifecycle/test_c8_tails.py owner name test fixture data, 3×
features/importance.py, shared/dialogue.py, tests/test_conflict_bm25.py мамочка one is an honorific dictionary, defensible; the comment is not

ruff, ruff format, mypy, full suite (2107 passed) — clean on commit.

…force it

Fixing the workflow that leaked was not enough, because the same leak came back
twice inside the same change:

- the CHANGELOG entry explaining the fix quoted the identity it was removing;
- the release.yml comment did the same, in a second file;
- and when this guard was written, its first CHANGELOG sentence quoted the
  assertion output, putting the name back a third time.

All three were caught by reading, and reading is what had already failed. So the
rule is a test now: tests/test_release_hygiene.py extracts every released section
from CHANGELOG.md the same way release.yml does, and checks it against the
anonymizer's own dictionary, privacy._ru_personas(). Reading the list from the
feature that hides these names means the guard cannot drift from what it
protects. Verified red — restoring the identity fails with the name reported.

Also in this commit:

- tests/test_primitives.py carried an owner name in a routing fixture. The route
  does not depend on the name (checked: any name, including a nonsense one,
  yields "user"), so the assertion holds with the name removed.
- The workflow comment and the CHANGELOG entry now describe the leak without
  reproducing it, which was the whole point of the exercise.

What this does NOT do: the identity list itself is untouched. config.yaml
rag.ru_personas, rag/synonyms.py and the privacy tests ARE the feature that hides
these names; deleting them would remove the anonymizer. A separate tree-wide
sweep remains — 21 occurrences in 6 files, none in the release path — and is
reported rather than bundled here.
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: Cipher208/a-memory/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bba4fc46-a9c4-4d26-b9a7-20f54dffde62
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Cipher208
Cipher208 merged commit a538c28 into master Oct 8, 2026
19 checks passed
@Cipher208
Cipher208 deleted the fix/release-body-must-not-quote-identities branch October 8, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant