fix(graph): give the zero-results miner the same honest-failure contract

[Cipher208]

Same shape as the bug just fixed in miner_embedding (#84), found by grepping the file after that fix landed.

The bug

    try:
        ...
        for r in rows:
            await g.find_or_add_entity(...)
            surfaced += 1
    except Exception:
        logger.debug("zero-result surfacing failed", exc_info=True)
        return {"edges": 0}

{"edges": 0} is the value meaning "there was nothing to surface", and the reason is reported at debug, which is invisible at the level this service runs at. A failure in find_or_add_entity therefore looked exactly like a quiet night, and no trace reached memory.log.

Why it matters now

After #84, 0 means something specific: this miner looked and found no work. Leaving a second path that returns 0 on failure would make that contract a lie again — and the new per-miner log line (miner edges: layer=user ... zero_results=0) could not tell the two apart either.

The fix

The exception escapes to the handler in graph_enrich that records edges: -1 with a warning. The reachable return {"edges": 0} for "the journal had no repeated misses" stays — that one is genuine.

Scope

This was the only other swallow in the file. The remaining except Exception in graph_miners is _get_ner, which probes whether spaCy is installed: a legitimate probe, not a miner, and correctly silent.

Tests

One new: a backend failure escapes miner_zero_results. The two existing zero-result tests still pin the genuine zero (edges == 0 when the journal has one miss, >= 1 when it repeats), so the change is scoped to the failure path only.

Full suite: 2086 passed.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Repository: Cipher208/a-memory/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4a4ac503-fe94-4392-a02f-ed72becff171

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}