docs(olympics): document all 25 settings, and record two live defects - #411
Open
ChuckBuilds wants to merge 1 commit into
Open
docs(olympics): document all 25 settings, and record two live defects#411ChuckBuilds wants to merge 1 commit into
ChuckBuilds wants to merge 1 commit into
Conversation
The configuration section listed 7 of the 25 settings, and four of the seven were wrong: - display_duration was given as 15; the schema default is 30. - update_interval was given as 3600; the schema default is 300. - logo_size does not exist in the schema. Because the schema sets additionalProperties: false, the README's own example configuration -- which includes it -- is rejected rather than ignored. A troubleshooting line also told people to reduce it when text does not fit. - The whole "Transitions" section documented transition.type, .speed and .enabled as working. Nothing in the plugin reads them, and neither does high_performance_transitions (#381). Meanwhile the eighteen settings that do work were undocumented, including every one that decides what appears: show_medals, show_schedule, show_results, medal_race_enabled, top_countries_count, rival_countries, sport_filters, vegas_mode and the notification block. All 25 are now covered, grouped, with the four dead ones marked as such. Also records two defects on the countdown screen, filed as #410: The day count has been negative since February 2026. The plugin carries one hardcoded Games -- Milano Cortina, opening 2026-02-06 -- and _calculate_days_until returns a plain difference with no floor and nothing to roll on to, so it now renders "-209 DAYS UNTIL WINTER OLYMPICS". The README had claimed dates for 2028, 2030 and 2032 are included; grepping the plugin for those years returns nothing. "DAYS UNTIL" is clipped on every panel narrower than 256, because the lines are centred in the right half and the label is wider than that half. This one is not silent: check_plugin.py fails six of its eight sizes on it, reproduced on a clean tree, so the plugin is currently failing its own harness on main. No code changed here; the screenshots show the current behaviour rather than a size where it happens to look right. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configuration section was mostly wrong
It listed 7 of the 25 settings, and four of those seven were incorrect:
display_durationdefault15update_intervaldefault3600logo_size(8–64)transition.type/.speed/.enabledThe
logo_sizeone bites twice. The schema setsadditionalProperties: false, so the README's own example configuration — which includeslogo_size— is rejected, not ignored. A troubleshooting line also advised reducing it when text does not fit.Meanwhile the eighteen settings that actually work were undocumented, including every one that decides what appears on screen:
show_medals,show_schedule,show_results,medal_race_enabled,live_alerts_enabled,top_countries_count,rival_countries,sport_filters,vegas_mode, and the whole notification block.All 25 are now documented and grouped, with the four dead ones (
transition.*plushigh_performance_transitions, per #381) in a section that says plainly that they do nothing.Two live defects, filed as #410
The countdown is negative right now. The plugin carries a single hardcoded Games:
and
_calculate_days_untilreturns(target - today).dayswith no floor and nothing to roll forward to. Since those Games closed it has rendered-209 DAYS UNTIL WINTER OLYMPICS. The README claimed dates for 2028, 2030 and 2032 are included — grepping the plugin for those years returns nothing.DAYS UNTILis clipped below 256px, because the lines are centred in the right half of the panel and the label is wider than that half.64x32loses most of it and overlaps the rings.I initially assumed this was a silent draw-time clip like the ones in
web-ui-infoandledmatrix-weather. It is not —check_plugin.pyfails six of its eight sizes on it, and the two that pass are exactly the 256-wide ones:Reproduced on a clean tree with no local changes, so this plugin is currently failing its own safety harness on
main. I corrected the issue text after finding this — my first write-up said the harness passed.What I did not do
No code changed. Fixing the negative countdown needs a decision I did not want to take unilaterally — add the future Games and roll forward, or clamp and show "games over" — and the clipping needs layout work across eight sizes. Both are described in #410 with the evidence.
The screenshots show the current behaviour, including the clipped
DAYS UNTI, rather than a panel size where it happens to fit.Docs only. 2.0.1 → 2.0.2.
🤖 Generated with Claude Code