docs(calendar): replace the ASCII mock-ups with real renders - #389
Open
ChuckBuilds wants to merge 1 commit into
Open
docs(calendar): replace the ASCII mock-ups with real renders#389ChuckBuilds wants to merge 1 commit into
ChuckBuilds wants to merge 1 commit into
Conversation
The README described the display with three hand-drawn text sketches:
03/15 2:30pm
Team Meeting
They are now real plugin output at the true panel size -- a timed event, an
all-day event, a long title being ellipsized, and the empty state -- plus a
panel-size sheet.
Also documents google_auth, the one setting the reference did not mention. It
is not a value you type: it is the web UI's "Connect Your Google Account"
button (x-widget: google-oauth). The two combined customization rows are split
so each key appears on its own, which takes the plugin to 13 of 13 settings
documented by key.
Rendering these needed the shots "attrs" seam from #386, which is not on main
yet; the identical change to sitecustomize.py and render_docs_assets.py is
included here so this branch can render on its own.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 17 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The README explained the display with three hand-drawn sketches:
Those are now real plugin output at the true panel size, covering the four screens the plugin can show — a timed event, an all-day event, a long title being ellipsized, and the empty state — plus a panel-size sheet.
The long-title render is the interesting one: it confirms the ellipsis behaviour the code comment describes, where a title that wrapped past the visible lines ends
Rev...rather than just stopping.Settings
google_authwas the one setting the configuration reference did not mention. It is not a value you type — it is the web UI's Connect Your Google Account button (x-widget: google-oauth), and the entry now says so and points at the consent flow already documented above it.The two combined
customization.*rows are split so each key has its own line. That takes the plugin to 13 of 13 settings documented by key; the config-token audit drops nothing.Also verified: the README's
manager.py:346-348reference toInstalledAppFlow.run_local_server()still points at the right code (it is at line 347).A note on the tooling diff
Rendering these needed the shots
attrsseam — runtime state applied to the plugin instance after the loader builds it, since this plugin's events arrive from Google rather than from configuration. That seam is in #386 and not on main yet, so the identical change tositecustomize.pyandrender_docs_assets.pyis included here to let this branch render on its own. Whichever merges first, the other's copy of those two files should apply cleanly.Checks
check_plugin.py: 8/8 passrender_docs_assets.py --check: both composites and the hero reproduceDocs only. 1.2.3 → 1.2.4.
🤖 Generated with Claude Code