chore(flights): drop the committed debug images - #312
Conversation
debug_composite.png and debug_cropped.png are output, not assets. The map
composer writes them with Path("debug_composite.png") -- a relative path, so
on an install they land in the process working directory, which is the core
checkout. A running rig accordingly carries two untracked files in its
LEDMatrix repo, and copies of them were committed here as well.
Untracked files in a checkout are harmless until upstream adds a file at the
same path, at which point the pull refuses. There is no reason to leave that
waiting.
Removed and added to .gitignore so they cannot come back. #305 is what stops
them being written at all unless debug logging is on, and puts them under the
tile cache directory rather than the CWD; this only clears what was already
committed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01STMbQE4YctTacQXfbYqKuW
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
|
Superseded by #314, which combines the four ledmatrix-flights PRs into one version bump. Every change from this PR is verified present on that branch; the branch here is untouched if you want to compare. |
2 participants
debug_composite.pnganddebug_cropped.pngare output, not assets.The map composer writes them with
Path("debug_composite.png")— a relative path, so on an install they land in the process working directory, which is the core checkout. A running rig accordingly carries two untracked files in its LEDMatrix repo (I saw exactly that on devpi), and copies were committed here as well.Untracked files in a checkout are harmless right up until upstream adds a file at the same path, at which point the pull refuses with "untracked working tree files would be overwritten". There is no reason to leave that waiting.
Removed and added to
.gitignoreso they cannot come back.Scope: this only clears what was already committed. #305 is what stops them being written at all unless debug logging is on, and moves them under the tile cache directory rather than the CWD. The two are independent — this touches no Python.
Version 1.12.17, above the 1.12.14/1.12.15/1.12.16 claimed by #304, #305 and #307.