Skip to content

feat(of-the-day): user-customizable fonts/colors/offsets via x-style-elements (v1.3.0) - #188

Merged
ChuckBuilds merged 2 commits into
mainfrom
feat/of-the-day-element-styles
Jul 17, 2026
Merged

feat(of-the-day): user-customizable fonts/colors/offsets via x-style-elements (v1.3.0)#188
ChuckBuilds merged 2 commits into
mainfrom
feat/of-the-day-element-styles

Conversation

@ChuckBuilds

Copy link
Copy Markdown
Owner

Summary

First adopter of the core x-style-elements system (ChuckBuilds/LEDMatrix#394): the schema declares two styleable elements (`title_text`, `body_text`) in ~20 lines and the core expands them into full font/size/color/x-y-offset config UI — the plugin had zero customization before and gains all of it with one small helper in the renderer.

Purely additive: with an untouched config (bare, or carrying the schema defaults the web UI bakes in on every save) rendering is byte-identical to v1.2.0. On older cores the declaration is simply not expanded (no new UI appears) and a guarded import keeps the classic styling path.

Verification

  • Byte-identical old-vs-new across 5 sizes x both screens x both config shapes (20 comparisons); overrides verified to engage (size/color/offset each change the render).
  • Full safety harness passes; 9 regression tests.
  • Verified end-to-end on the devpi: style fields render in the real web UI, live preview shows unsaved changes, and a saved red-title override displayed on the physical 192x48 panel.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FqzC1nzTWL4kaqgMaQZFam

…elements (v1.3.0)

First adopter of the core's x-style-elements system: the schema declares
two styleable elements (title_text, body_text) in ~20 lines and the core
expands them into full font/size/color/x-y-offset config blocks — no
hand-copied property blocks, and the plugin code resolves them through
src.element_style in one helper.

Purely additive: with an untouched config (bare, or carrying the schema
defaults the web UI bakes in on every save) rendering is byte-identical
to v1.2.0 (verified across 5 sizes x both screens x both config shapes).
On older cores the declaration is simply not expanded (no customization
UI appears) and a guarded import keeps the classic styling path.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FqzC1nzTWL4kaqgMaQZFam
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@ChuckBuilds, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7679f2ff-375c-4176-94ca-c10027ae27e4

📥 Commits

Reviewing files that changed from the base of the PR and between 5c84118 and c6246b3.

📒 Files selected for processing (5)
  • plugins.json
  • plugins/of-the-day/config_schema.json
  • plugins/of-the-day/manager.py
  • plugins/of-the-day/manifest.json
  • plugins/of-the-day/test_element_styles.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/of-the-day-element-styles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Jul 11, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 12 complexity

Metric Results
Complexity 12

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ChuckBuilds

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@ChuckBuilds

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

…ssignment

- Remove unused `from datetime import date` (F401).
- Remove dead `style = ...` assignment that was never read (F841) — the
  resolver is accessed directly via p._element_style_resolver two lines
  later.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KEZK1P1Q1fu5pcuVrkrCFZ
@ChuckBuilds
ChuckBuilds merged commit 535f066 into main Jul 17, 2026
3 of 4 checks passed
@ChuckBuilds
ChuckBuilds deleted the feat/of-the-day-element-styles branch August 5, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant