Skip to content

chore(assets): add 4 missing NCAA team logos (march-madness) - #415

Merged
ChuckBuilds merged 1 commit into
mainfrom
chore/ncaa-logos-march-madness
Jul 15, 2026
Merged

chore(assets): add 4 missing NCAA team logos (march-madness)#415
ChuckBuilds merged 1 commit into
mainfrom
chore/ncaa-logos-march-madness

Conversation

@ChuckBuilds

Copy link
Copy Markdown
Owner

Summary

Split out of PR #412 (chore/dead-code-removal). march-madness is already live in ledmatrix-plugins (version 1.0.1, ahead of the stale local copy that got accidentally committed to core in #412 -- nothing else needed there). It loads team logos at runtime from assets/sports/ncaa_logos/<ABBR>.png (manager.py:233), and these 4 teams (COLGATE, LEHIGH, MICHIGAN, RUTGERS) were missing from that shared cache.

No code changes -- just the 4 binary assets.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KEZK1P1Q1fu5pcuVrkrCFZ

…, LEHIGH, MICHIGAN, RUTGERS)

march-madness (already live in ledmatrix-plugins) loads team logos from
this shared assets/sports/ncaa_logos/<ABBR>.png cache at runtime
(manager.py:233) -- these 4 were missing.

Split out of PR #412 (chore/dead-code-removal), which had accidentally
bundled these in alongside unrelated dead-code deletions.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KEZK1P1Q1fu5pcuVrkrCFZ
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • assets/sports/ncaa_logos/COLGATE.png is excluded by !**/*.png
  • assets/sports/ncaa_logos/LEHIGH.png is excluded by !**/*.png
  • assets/sports/ncaa_logos/MICHIGAN.png is excluded by !**/*.png
  • assets/sports/ncaa_logos/RUTGERS.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 78b5ac5c-0fcd-4c60-9e2a-ff1532dac6fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ncaa-logos-march-madness

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ChuckBuilds
ChuckBuilds merged commit 9db1d23 into main Jul 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant