fix(check): respect user's npm registry configuration#1976
Closed
Will-hxw wants to merge 6 commits intoChromeDevTools:mainfrom
Closed
fix(check): respect user's npm registry configuration#1976Will-hxw wants to merge 6 commits intoChromeDevTools:mainfrom
Will-hxw wants to merge 6 commits intoChromeDevTools:mainfrom
Conversation
Issue #1932: Tools within each category should be sorted with no-arg tools first, followed by tools with required args, then tools with only optional args. This matches the requested ordering in the issue. Updated both the TOC generation (generateToolsTOC) and the main reference generation (generateReference) to use the new sort order. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Issue #1941: The click tool description did not make clear that for <select> dropdowns or comboboxes, the 'fill' tool should be used instead. The fill tool can select options directly without needing to expand the dropdown first. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add limit and query parameters to list_pages tool to address Issue #1921. When many browser tabs are open, listing all pages can cause token budget issues and browser hangs. These parameters allow truncating and filtering the page list: - limit: maximum number of pages to return - query: filter pages by URL containing the query string The URL dump in McpResponse.build() now respects these options and shows a note when pages are truncated (e.g., 'showing 10 of 50').
Use npm_config_registry env var if set, falling back to the public registry only if no custom registry is configured. This allows corporate proxy and private registry users to avoid blocked requests. Fixes #1943
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
Thank you for the reminder. I understand that as a first-time contributor to this Google open source project, I need to sign the Contributor License Agreement (CLA). Regarding the CLA check failure:
Regarding the merge conflict:
Please let me know if there are any other requirements I need to fulfill before this PR can be merged. |
Resolve conflict in McpResponse.ts: - Keep PR's page limit/query feature (#pageLimit, #pageQuery, setPageListOptions) - Keep main's error handling feature (#error, setError, error getter) - Keep main's heap snapshot sorting with isNodeLike
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm_config_registryenvironment variable if set, falling back to public registry only if no custom registry is configuredTest plan
🤖 Generated with Claude Code