fix(#262): resolve WCAG AA contrast violations across codebase#263
Merged
Conversation
- Replace --accent (#ee2c80, 3.95:1) with --accent-active (#b5116a, ~6.45:1) on filled backgrounds with white text: Home CTA, MuscleMapConfirm pills + Save CTA, Settings save button, Report add-to-library button - Add --accent-soft: #b5116a override to [data-theme="g10"] block so accent-soft text on tinted backgrounds passes AA in light mode (~4.84:1 vs ~1.77:1 before) - Fix OvelsePicker 10px exercise label on --exercise-soft bg: change color from --exercise to --cds-text-primary (green identity kept via border + icon) - Remove inline outline:none from raw <input> elements in ExFlyt, GruppetimePicker, OvelsePicker, Planlegger; broaden app.css focus rule to cover non-Carbon inputs - Bump version to 1.5.16 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-090dfd003-263.westeurope.7.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
1.
--accent→--accent-activeon filled backgrounds with white text--accent(#ee2c80) as a background withcolor: #fffproduces 3.95:1 — fails AA for normal text (requires 4.5:1). Replaced with--accent-active(#b5116a, ~6.45:1) in five locations:Home.jsx— CTA "Log" buttonMuscleMapConfirm.jsx— Today / Other day segmented pills + Save CTASettings.jsx— Save display-name buttonReport.jsx— add-to-library (+) button in recommendations2.
--accent-softoverride for light mode--accent-soft: #ff7eb6as text on--accent-bg-14in light mode computes to ~1.77:1 (FAIL). Added--accent-soft: #b5116ato the[data-theme="g10"]block incarbon-tokens.css. Dark mode keeps#ff7eb6(~7.7:1 on dark bg). FixesAccentChipand all accent-soft text labels in light mode.3.
OvelsePickerexercise label on green-soft background10px mono label used
--exercise(#1a8c4e in light mode) as text on--exercise-softbackground → 3.79:1 (FAIL). Changed to--cds-text-primary. Green identity preserved via border andAddicon.4. Focus rings on raw
<input>elementsInline
outline: noneon custom-styled text inputs inExFlyt,GruppetimePicker,OvelsePicker, andPlanleggersuppressed keyboard focus rings with no replacement. Removed all four. Extendedapp.cssfocus rule frominput[type=number]to all non-Carbon inputs.5.
CLAUDE.mdrule addedAdded an explicit WCAG rule to the key-tokens section: never use
--accentas a filled background with white text — always use--accent-active.Test plan
#262
🤖 Generated with Claude Code