fix(#255): add required app_location to cleanup-staging close steps#257
Merged
Merged
Conversation
Replaces mutable @v1 tag with the exact commit SHA it resolves to (1a947af) in both ci.yml and cleanup-staging.yml, eliminating the supply-chain risk of a tag being silently updated to run arbitrary code in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Azure/static-web-apps-deploy marks app_location as required in its action.yml schema. The close action doesn't use it at runtime, but omitting it causes VS Code/actionlint to flag both steps. Matches the value used in ci.yml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-090dfd003-257.westeurope.7.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_locationis markedrequired: truein the Azure SWA action's schema — bothclosesteps incleanup-staging.ymlwere missing it, causing the 2 VS Code / actionlint problemsaction: "close"(the action just deprovisions the PR env), but needs to be present to satisfy the schema validatorapp/distto matchci.ymlTest plan
cleanup-staging.ymlCloses #255
🤖 Generated with Claude Code