fix(ci): reusable validate secret must be schema_token (not schema-token) - #279
Merged
Conversation
GitHub secret identifiers allow only alphanumerics + underscore — a hyphen in a workflow_call `secrets:` key is invalid, so `schema-token` would reject the call. Rename to schema_token (declaration + env ref + caller example). Inputs (schema-ref/shapes-path) keep hyphens — those are allowed for inputs. The Homelab.Stacks.SmartHome caller (#278) already uses schema_token. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix to D2 (#276). GitHub secret identifiers allow only alphanumerics + underscore — a hyphen in a
workflow_callsecrets:key is invalid, soschema-tokenwould reject the reusable-workflow call._validate-shapes.yml:schema-token→schema_token(secret declaration +GH_TOKENenv ref + caller example comment).schema-ref,shapes-path) keep hyphens — allowed for inputs, only secrets are restricted.The SmartHome caller (#278) already uses
schema_token, so once this +SCHEMA_RO_PATland, the opt-in validation goes green.Refs #272.
🤖 Generated with Claude Code