Skip to content

Rework foss filtering#4696

Open
4hm3dn3d41 wants to merge 2 commits into
ChrisTitusTech:mainfrom
4hm3dn3d41:Rework-FOSS-Filtering
Open

Rework foss filtering#4696
4hm3dn3d41 wants to merge 2 commits into
ChrisTitusTech:mainfrom
4hm3dn3d41:Rework-FOSS-Filtering

Conversation

@4hm3dn3d41

@4hm3dn3d41 4hm3dn3d41 commented Jun 12, 2026

Copy link
Copy Markdown

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactor
  • UI/UX improvement

Description

image

Removed the separate FOSS toggle and replaced it with an inline FOSS label.

Remove the separate "Highlight FOSS" toggle and its theming logic, and instead append an inline "- FOSS" label to FOSS app entries. Changes: remove WPFToggleFOSSHighlight from app navigation and related event handlers, delete FOSSColor resource updates in theme code and button handler, simplify checkbox setup in Invoke-WPFUIElements by removing the special-case toggle logic, and update Initialize-InstallAppEntry to build a horizontal panel containing the app name plus a small green "- FOSS" TextBlock for FOSS items. This consolidates FOSS indication into the item UI and cleans up toggle/theme handling.
Replace the separate StackPanel/TextBlock used for the FOSS indicator with an inline System.Windows.Documents.Run appended to the app name. The run is styled (green RGB(76,175,80) and FontSize=10) and the checkbox content assignment was moved outside the conditional so the appName (with optional FOSS run) is always used. Cleaned up related comments to reflect the FOSS label change.
@GabiNun2

Copy link
Copy Markdown
Contributor

looks kinda ugly

@4hm3dn3d41

Copy link
Copy Markdown
Author

i think its better but if you have any ideas...

@GabiNun2

Copy link
Copy Markdown
Contributor

i think its better but if you have any ideas...

my idea would be to not change it and add a thing to explain what foss is

@4hm3dn3d41

Copy link
Copy Markdown
Author
image

I tried icons theyre just hard to understand

@GabiNun2

Copy link
Copy Markdown
Contributor
image I tried icons theyre just hard to understand

no like under the foss toggle it should explain what foss is

@4hm3dn3d41

Copy link
Copy Markdown
Author

i think its better but if you have any ideas...

my idea would be to not change it and add a thing to explain what foss is

I think if you understand what open source is then you know what foss is as well

@GabiNun2

Copy link
Copy Markdown
Contributor

i think its better but if you have any ideas...

my idea would be to not change it and add a thing to explain what foss is

I think if you understand what open source is then you know what foss is as well

some people don't know what foss is

@4hm3dn3d41

Copy link
Copy Markdown
Author

the main point is i dont think it needs a toggle ; )

@GabiNun2

Copy link
Copy Markdown
Contributor

the main point is i dont think it needs a toggle ; )

but this looks alot worse than it is now

@github-actions github-actions Bot added bug Something isn't working ui update UI/UX improvements labels Jun 13, 2026
@4hm3dn3d41

Copy link
Copy Markdown
Author
image

most foss software already mentions that it is open source in its description
this pr just makes it easier to find

@GabiNun2

Copy link
Copy Markdown
Contributor
image most foss software already mentions that it is open source in its description this pr just makes it easier to find

it still looks ugly compare to the current version

@4hm3dn3d41

Copy link
Copy Markdown
Author
image most foss software already mentions that it is open source in its description this pr just makes it easier to find

it still looks ugly compare to the current version

i dont this so #4414 (comment)

@4hm3dn3d41

Copy link
Copy Markdown
Author

i think its better but if you have any ideas...

my idea would be to not change it and add a thing to explain what foss is

the green color doesnt indicate that its foss

@GabiNun2

Copy link
Copy Markdown
Contributor
image most foss software already mentions that it is open source in its description this pr just makes it easier to find

it still looks ugly compare to the current version

i dont this so #4414 (comment)

just add text under foss toggle explaining what it is

@vyas-devgna

Copy link
Copy Markdown
Contributor

maybe just a small green dot like an indicator and a small few words explanation in the bottom of side panel , give this a try ig

@vyas-devgna

Copy link
Copy Markdown
Contributor

maybe just a small green dot like an indicator and a small few words explanation in the bottom of side panel , give this a try ig

the people who care about it will notice it and people who dont can ignore it better

@vyas-devgna

Copy link
Copy Markdown
Contributor

maybe just a small green dot like an indicator and a small few words explanation in the bottom of side panel , give this a try ig

the people who care about it will notice it and people who dont can ignore it better

image image

AI GENERATED FOR AN EASY PREVIEW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ui update UI/UX improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants