Repository navigation
fix(list): satisfy clippy's needless_range_loop on Rust 1.100 - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI installs the latest stable Rust. Rust 1.100's clippy added
needless_range_loopforrow_atinsrc/list/app.rs, socargo clippy --all-targets -- -D warningsnow fails on main, and every open PR'stestjob fails on that line, even PRs that don't touch it (#28, #29, #30, #31, #32).Fix
row_atiterates the rows directly (iter().enumerate().skip(list_offset)) instead of indexing. Same behavior: an offset past the end still yields no row.Proof
On Rust 1.100.0:
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass on this branch. They also pass on each of #28–#32 with this commit merged in.