Add runner type to ClassicAllocator - #560
Draft
prozacchiwawa wants to merge 2 commits into
Draft
prozacchiwawa wants to merge 2 commits into
prozacchiwawa wants to merge 2 commits into
Conversation
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
Co-authored-by: arty <prozacchiwawa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClassicAllocator, constrained to clone and dereference toTRunProgramRc<dyn TRunProgram>for both existing allocator implementationsTesting
cargo check --all-targetscargo test --lib tests::classic::stage_2(17 passed)cargo test --lib -- --skip compile_performance_suite(705 passed, 1 ignored, 1 filtered)rustfmt --edition 2021 --checkon all changed Rust filesThe unfiltered library suite reached only the existing long-running
compile_performance_suite; it was stopped after the other tests completed and then rerun successfully with that performance test excluded.