Remove function cache and artifact cache - #531
Merged
Merged
Conversation
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core codegen and module compile paths; behavior should match a cold compile but compile time and I/O patterns change, with no remaining cache invalidation edge cases.
Overview
Removes two compile caches so compilation always does full codegen and file output instead of reusing prior results.
In-memory
Funcacheis deleted:FunctionEntry,get_function_cache_key, env filtering helpers, and thedependency_graphparameter oncodegen/codegen_. Out-of-linedefunbodies are always generated and no longer looked up or stored inBasicCompileContext. The deinline pass still builds a dependency graph for module-phase helper pruning but no longer seeds or passes a cache intocodegen.On-disk module cache is removed entirely: the
diskcachemodule,try_from_cache/get_hex_name_of_export, andset_cache_elementcalls when writing export hex. Module compilation incompile_pre_formsno longer short-circuits on.chialisp/<key>/hits.Tests for both mechanisms (
codegen_funcache,module_cache, cache reuse inmodules.rs) and test-only FS helpers are dropped accordingly.Reviewed by Cursor Bugbot for commit 264e421. Bugbot is set up for automated code reviews on this repo. Configure here.