Skip to content

Remove function cache and artifact cache - #531

Merged
prozacchiwawa merged 1 commit into
mainfrom
remove-caches
Jul 24, 2026
Merged

prozacchiwawa merged 1 commit into
mainfrom
remove-caches

Conversation

@aqk

@aqk aqk commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Touches core codegen and module compile paths; behavior should match a cold compile but compile time and I/O patterns change, with no remaining cache invalidation edge cases.

Overview
Removes two compile caches so compilation always does full codegen and file output instead of reusing prior results.

In-memory Funcache is deleted: FunctionEntry, get_function_cache_key, env filtering helpers, and the dependency_graph parameter on codegen / codegen_. Out-of-line defun bodies are always generated and no longer looked up or stored in BasicCompileContext. The deinline pass still builds a dependency graph for module-phase helper pruning but no longer seeds or passes a cache into codegen.

On-disk module cache is removed entirely: the diskcache module, try_from_cache / get_hex_name_of_export, and set_cache_element calls when writing export hex. Module compilation in compile_pre_forms no longer short-circuits on .chialisp/<key>/ hits.

Tests for both mechanisms (codegen_funcache, module_cache, cache reuse in modules.rs) and test-only FS helpers are dropped accordingly.

Reviewed by Cursor Bugbot for commit 264e421. Bugbot is set up for automated code reviews on this repo. Configure here.

@prozacchiwawa prozacchiwawa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@prozacchiwawa
prozacchiwawa merged commit aefbbe7 into main Jul 24, 2026
38 checks passed
@prozacchiwawa
prozacchiwawa deleted the remove-caches branch July 24, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants