Repository navigation
Set default IncludeDesc fingerprint to zeros - #450
Merged
prozacchiwawa merged 3 commits intoApr 21, 2026
Merged
prozacchiwawa merged 3 commits into
prozacchiwawa merged 3 commits into
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 483a9ee. Configure here.
Contributor
Author
|
@SocketSecurity ignore cargo/zerocopy-derive@0.8.39 |
prozacchiwawa
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use an array of zero bytes instead of nil to represent "no fingerprint".
Doing this allows concatenation of an ordered set of signatures to uniquely represent that set.
Note
Medium Risk
Changes how include fingerprints are represented and concatenated into the on-disk cache key, which can affect cache hit/miss behavior across builds. Low functional risk beyond caching, but any mismatch in fingerprint population could cause incorrect reuse or unnecessary recompiles.
Overview
Normalizes include fingerprinting for caching.
IncludeDesc.fingerprintis changed from a variable-lengthVec<u8>to a fixed[u8; 32], with unknown fingerprints represented as 32 zero bytes.Fingerprint calculation paths now explicitly
try_into()the 32-byte tree hash, and the disk cache key builder concatenates fingerprints viaextend_from_slice, ensuring deterministic key material even when some includes previously had “no fingerprint”.Reviewed by Cursor Bugbot for commit 22924f4. Bugbot is set up for automated code reviews on this repo. Configure here.