Branch to make i64 paths into bigint for very large environments - #423
Merged
Merged
Conversation
…ions but fixes the bug in the new sigil.
prozacchiwawa
marked this pull request as ready for review
April 6, 2026 07:00
…what's supposed to happen
AmineKhaldi
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes environment path computation/encoding in codegen to avoid overflow on large environments, which can affect compiled output across dialect versions. While guarded by stepping/version logic and covered by a regression test, it touches core compilation behavior.
Overview
Fixes an overflow bug in environment path lookup during codegen by switching the internal path accumulator from
u64/i64math toNumber/bigint math, and adds a compatibility shim (early_stepping_truncate_to_u64) to preserve pre-cl-26output encoding.Introduces the
*standard-cl-26*dialect (and bumpsMAX_STEPPINGto26) and adds a regression test plus fixtures (test-env-overflow.clsp,test-env-overflow-cl24.hex) that compile/run a large-environment program to validate both the correctedcl-26behavior and stable legacycl-24output.Reviewed by Cursor Bugbot for commit b485352. Bugbot is set up for automated code reviews on this repo. Configure here.