module style 1: use compile context in more places - #326
Merged
Merged
Conversation
prozacchiwawa
marked this pull request as ready for review
February 17, 2026 10:09
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
aqk
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core compiler and evaluator plumbing by changing
compile_program/REPL/shrinker APIs to share a mutableBasicCompileContext, which could subtly affect allocator/symbol/optimizer state across nested compiles and macro evaluation.Overview
Refactors compilation entrypoints to use a shared
BasicCompileContext.CompilerOpts::compile_programnow takes&mut BasicCompileContext(instead of separate allocator/runner/symbol table), and call sites in codegen and optimizer are updated accordingly.Threads compile context through evaluation/minification flows. The REPL,
shrinktool, evaluator (shrink_bodyform+ macro expansion), preprocessor macro compilation, and WASM REPL invocation now build/use aBasicCompileContextand obtain optimizers viaget_optimizer, reducing ad-hoc allocator/symbol handling.Also updates pyo3 module constructors to the newer
Python<'_>signature and adjusts tests to the new context-based APIs.Written by Cursor Bugbot for commit 1cd7de3. This will update automatically on new commits. Configure here.