FIX-11: refuse video honestly at capture#35
Open
ChelseaKR wants to merge 1 commit into
Open
Conversation
habitable advertised capturing "short video," but video never reached a packet: capture._MEDIA_TYPES accepted .mp4/.mov and sealed the bytes, yet packet._EXT_BY_TYPE has no video entry and exif.make_shared_copy cannot strip video metadata (out of scope). The result was a capture that silently could not be shared or verified -- contradicting the honesty ethos. Implements the doc's short-term honest-refusal path (full pipeline stays EXP-07): - capture.py: drop .mp4/.mov from _MEDIA_TYPES; add an explicit guard that refuses any video suffix or explicit video/* media_type with a plain, actionable CaptureError before anything is hashed or sealed. - packet.py: note near _EXT_BY_TYPE that video is refused at capture (FIX-11/EXP-07); no video entry needed. - README.md, docs/evidence-method.md: drop/qualify the "short video" claim and state that video is not yet supported and why. - tests/test_vault_capture.py: cover refusal by .mp4/.mov suffix and by explicit media_type="video/mp4", asserting nothing is sealed or queued. - docs/ideation/02-large-scale-fixes.md: mark FIX-11 done. CaptureError already surfaces cleanly (CLI stderr, exit 1; appserver 400) via the existing HabitableError handlers -- verified end-to-end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
habitable advertised capturing "short video," but video never reached a
packet: capture._MEDIA_TYPES accepted .mp4/.mov and sealed the bytes, yet
packet._EXT_BY_TYPE has no video entry and exif.make_shared_copy cannot
strip video metadata (out of scope). The result was a capture that silently
could not be shared or verified -- contradicting the honesty ethos.
Implements the doc's short-term honest-refusal path (full pipeline stays
EXP-07):
refuses any video suffix or explicit video/* media_type with a plain,
actionable CaptureError before anything is hashed or sealed.
(FIX-11/EXP-07); no video entry needed.
and state that video is not yet supported and why.
explicit media_type="video/mp4", asserting nothing is sealed or queued.
CaptureError already surfaces cleanly (CLI stderr, exit 1; appserver 400)
via the existing HabitableError handlers -- verified end-to-end.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Backfill PR for a completed roadmap item (
roadmap/fix-11-resolve-the-half-supported-video-, 1 commit(s) overmain). Part of the portfolio roadmap batch.