refactor(web-core): extract the shared frontend substrate - #404
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 259 files, which is 159 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (57)
📒 Files selected for processing (259)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Claude finished @didinele's task in 4m 22s —— View job Review: extract the shared frontend substrate (
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| "dev": "next dev", | ||
| "build": "node ../../scripts/sync-web-core-assets.mjs website && next build", | ||
| "dev": "node ../../scripts/sync-web-core-assets.mjs website && next dev", | ||
| "start": "next start", |
There was a problem hiding this comment.
Minor / deployment consideration: build and dev re-run sync-web-core-assets.mjs, but start does not. Since the synced public/assets/fonts/ is gitignored and only produced by that script, next start relies on public/ having been populated by a prior build in the same working tree. That holds for the normal build && start flow, but is worth double-checking against the website's actual deploy: Next's standalone output does not automatically copy public/, so if the deploy artifact is assembled from a fresh checkout (where the sync never ran) the @font-face bytes will 404 — and per the script's own comment, a missing font src fails silently by falling back down the stack. Not a bug in this PR, just flagging the coupling so the deploy step is verified to carry the synced fonts.
|
Claude finished @didinele's task in 1m 59s —— View job Review: extract the shared frontend substrate (
|
| } | ||
| }, | ||
| }), | ||
| // The app's first `MutationCache`, and deliberately reporting-only: no banner, no toast, no UX change |
There was a problem hiding this comment.
Trivial: this comment moved verbatim from the app, so "The app's first MutationCache" now reads slightly off at package level -- it's the substrate's, shared by every app. Consider rewording.
Suggested change
| // The app's first `MutationCache`, and deliberately reporting-only: no banner, no toast, no UX change | |
| // The single `MutationCache` shared by every app, and deliberately reporting-only: no banner, no toast, no | |
| // UX change at all. `Button`'s catch and each form's own field-level errors already own the user-facing | |
| // half, and adding a second surface here would double up on every form that already handles its own failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.