updated ts spec files - #288
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeScript compilation target across the application and spec tsconfigs to align with a newer ECMAScript output level.
Changes:
- Bumped
app/tsconfig.jsoncompilerOptions.targetfromes2022toes2025. - Bumped
app/tsconfig.spec.jsoncompilerOptions.targetfromes2024toes2025.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/tsconfig.json | Updates the base TS compile target to es2025 for the app build configuration. |
| app/tsconfig.spec.json | Updates the spec/test TS compile target to es2025 to match the updated baseline. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
app/tsconfig.spec.json:8
tsconfig.spec.jsonnow extendstsconfig.json, which already setscompilerOptions.targettoes2025. Keeping a duplicatetargetoverride here is redundant and makes future target bumps easy to miss (the spec config can drift again). Consider removing the override and inheriting the target from the base config.
"module": "commonjs",
"target": "es2025",
"moduleResolution": "node16",
CharlieM312
force-pushed
the
feature/tsconfig-spec-update
branch
from
August 13, 2026 09:19
7466bbd to
990ed31
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (1)
app/tsconfig.json:3
- "target" is set to "es2025", but this tsconfig still declares "lib": ["es2022", "dom"]. That mismatch can lead to confusing type errors (newer built-ins not available in the type environment) and makes it unclear what the project is actually targeting. Consider aligning these settings (either keep target at ES2022 to match the lib, or bump lib to the same level / esnext if you truly want ES2025 features).
"target": "es2025",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.