Skip to content

updated ts spec files - #288

Merged
CharlieM312 merged 1 commit into
mainfrom
feature/tsconfig-spec-update
Aug 13, 2026
Merged

updated ts spec files#288
CharlieM312 merged 1 commit into
mainfrom
feature/tsconfig-spec-update

Conversation

@CharlieM312

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings August 13, 2026 09:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TypeScript compilation target across the application and spec tsconfigs to align with a newer ECMAScript output level.

Changes:

  • Bumped app/tsconfig.json compilerOptions.target from es2022 to es2025.
  • Bumped app/tsconfig.spec.json compilerOptions.target from es2024 to es2025.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
app/tsconfig.json Updates the base TS compile target to es2025 for the app build configuration.
app/tsconfig.spec.json Updates the spec/test TS compile target to es2025 to match the updated baseline.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings August 13, 2026 09:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

app/tsconfig.spec.json:8

  • tsconfig.spec.json now extends tsconfig.json, which already sets compilerOptions.target to es2025. Keeping a duplicate target override here is redundant and makes future target bumps easy to miss (the spec config can drift again). Consider removing the override and inheriting the target from the base config.
        "module": "commonjs",
        "target": "es2025",
        "moduleResolution": "node16",

Copilot AI review requested due to automatic review settings August 13, 2026 09:19
@CharlieM312
CharlieM312 force-pushed the feature/tsconfig-spec-update branch from 7466bbd to 990ed31 Compare August 13, 2026 09:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (1)

app/tsconfig.json:3

  • "target" is set to "es2025", but this tsconfig still declares "lib": ["es2022", "dom"]. That mismatch can lead to confusing type errors (newer built-ins not available in the type environment) and makes it unclear what the project is actually targeting. Consider aligning these settings (either keep target at ES2022 to match the lib, or bump lib to the same level / esnext if you truly want ES2025 features).
    "target": "es2025",

@CharlieM312
CharlieM312 merged commit 21746b7 into main Aug 13, 2026
14 checks passed
@CharlieM312
CharlieM312 deleted the feature/tsconfig-spec-update branch August 13, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants