Fix author-name collisions and series-set release searches - #137
Open
jonnotk wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix two causes of empty book searches, reproduced on 0.9.958:
Isaac Asimov The Naked Sun 2011 RETAiL EPUB eBook-NODEis rejected as a different book when the catalogue also containsIsaac Asimov. Ignore a contradictory title that tokenizes to the author's name. Other sibling-title checks remain active, includingFoundation and EmpireversusFoundation.Galactic Empire Series 3 Books Setqueries every packaging term and returns nothing, although the indexer hasGalactic Empire series by Isaac Asimov EPUB. Remove trailing numeric box-set packaging from the query. For titles explicitly naming a series set, also allow a matching variant that retainsSeriesand omits the retail book count. Reject that variant if the release adds a volume/count or another title, including under default Balanced matching. The selected catalogue title stays unchanged.This does not disable quality, language, pack, existing-file or other identity checks. It does not add general multi-book import support.
Database Migration
No.
How was this tested?
Chaptarr.Core.Testsuite on currentdevelop: 3,040 passed using .NET SDK 10.0.401 on macOS x64.v0.9.958source for the live installation: 3,028 passed in its full suite.downloadAllowed: trueand no rejections. No download/import was triggered for this validation.Test command, after restore/build:
LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 dotnet test src/Chaptarr.Core.Test/Chaptarr.Core.Test.csproj -c Release --no-build --no-restoreBuild/restore used
-p:WarningsNotAsErrors=NU1902for the existingMicrosoft.Build.Tasks.Git8.0.0 advisory. The initial full run under the workstation's Portuguese locale hit an unrelated M4B duration-message assertion (23,4mversus23.4m); the English-locale run passed. Neither dependency versions nor that test were changed.Screenshots (UI changes only)
No frontend changes.