fix: bulk delete author files - #134
Open
benjitobz wants to merge 2 commits into
Open
Conversation
The author editor's delete endpoint passed a hardcoded false for deleteFiles, so 'Delete Files' selected in the mass-editor delete dialog was silently discarded and author folders were left on disk. Deleting a single author from its detail page was unaffected, which made the difference look like a UI bug. The resource already carries the flag the client sends; pass it through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The author editor's delete endpoint passed a hardcoded false for deleteFiles, so "Delete Files" selected in the mass-editor delete dialog was silently discarded and author folders were left on disk. Deleting a single author from its detail page was unaffected, which made the difference look like a UI bug. The resource already carries the flag the client sends; pass it through.
Fixes # - Didn't see an issue for this yet
Database Migration
NO
How was this tested?
Docker (linux/amd64) on an Ubuntu server host, image built with Dockerfile.build.
Steps to reproduce:
A note on AI: We know AI/agentic coding is everywhere and only getting
more popular. We won't insist that you disclose whether you used it or which
models you used, but in the same spirit, please don't take offense if your PR
is scrutinized and changes are requested.
Review time: The longer the PR and the more lines changed, the longer the
review will take. Small, focused PRs merge fastest. If yours is big, please be
patient.