Skip to content

UI: Fix input placeholder contrast and focus styling in dark mode #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jberlyn wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

UI: Fix input placeholder contrast and focus styling in dark mode #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions frontend/src/Author/Details/FilterSearchInput.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,22 @@
padding-left: 38px;
padding-right: 30px;
height: 35px;
border-radius: 20px;
border: 1px solid var(--inputBorderColor);
border-radius: 20px;
background-color: var(--inputBackgroundColor);
color: var(--textColor);
transition: all 0.2s ease-in-out;

&::placeholder {
color: var(--gray);
opacity: 1;
}
}

.searchInput:focus {
outline: 0;
border-color: var(--inputFocusBorderColor);
box-shadow: 0 0 0 1px var(--inputFocusBorderColor);
background-color: var(--white);
}

.clearIcon {
Expand Down
5 changes: 5 additions & 0 deletions frontend/src/Components/Form/Input.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
box-shadow: inset 0 1px 1px var(--inputBoxShadowColor);
color: var(--textColor);

&::placeholder {
color: var(--gray);
opacity: 1;
}

&:focus {
outline: 0;
border-color: var(--inputFocusBorderColor);
Expand Down
6 changes: 6 additions & 0 deletions frontend/src/Styles/scaffolding.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ textarea {
line-height: 1.528571429; /* 20/14 */
}

input::placeholder,
textarea::placeholder {
color: var(--gray);
opacity: 1;
}

/* Better defaults for unordererd lists */

ul {
Expand Down