fix: defer using proposer duties v2 to gloas#9519
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request defers the transition to the deterministic 1-epoch lookahead (EIP-7917) and the getProposerDutiesV2 endpoint from the Fulu fork to the Gloas fork to avoid depending on an endpoint that is not yet implemented by all clients. The review feedback points out that isForkPostFulu is still required in onNewHead to correctly determine the proposer dependent root during the Fulu fork, and suggests keeping its import alongside isForkPostGloas.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1674755657
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+151
to
152
| if (isForkPostGloas(this.config.getForkName(computeStartSlotAtEpoch(nextEpoch)))) { | ||
| await this.pollBeaconProposers(nextEpoch); |
There was a problem hiding this comment.
When the current epoch is the final Fulu epoch, nextEpoch already resolves to ForkName.gloas, so this branch calls pollBeaconProposers(nextEpoch) immediately and that method selects getProposerDutiesV2 for the requested epoch. That still hits /eth/v2/validator/duties/proposer before the chain has reached Gloas—the compatibility case this change is trying to avoid—and if the connected BN does not serve v2 yet the prefetch fails; the last-slot boundary poll is also skipped because slot + 1 is Gloas, leaving first-Gloas-slot proposer duties to a boundary-time race.
Useful? React with 👍 / 👎.
Member
Author
There was a problem hiding this comment.
that's fine, at this point every bn should have proposer duties v2 implemented as node operators have to upgrade before the fork happens, ideally multiple epochs before
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per #9380 (comment), we cannot use getProposerDutiesV2 before gloas as clients might not have it implemented yet