fix: gas optimizations for progress-tracker and learn-token (#131, #132, #133) - #170
Merged
DeFiVC merged 4 commits intoJul 29, 2026
Conversation
…odules Replace O(n) storage iteration in count_completed_modules with modules_completed_bitmap.count_ones(). The bitmap already tracks completed module indices, so popcount gives the same result in O(1) without any persistent storage reads. Simplify calculate_progress and is_eligible_for_credential signatures to remove parameters that are no longer needed. Closes ChainLearnOfficial#131
average_quiz_score already uses the running sum (total_quiz_score) and count (quizzes_submitted) maintained in ProgressInfo, making it O(1) with no Vec iteration. Add documentation making this explicit. Closes ChainLearnOfficial#132
Replace ProgressTrackerClient::new() with env.invoke_contract() in claim_reward. Client instantiation has non-trivial gas cost and is wasted when only a single cross-contract call is needed. Closes ChainLearnOfficial#133
|
@Ojukwu-Chinedu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Resolve three gas optimization issues: