fix: sitemap omits chain URLs on error (prod smoke blocker) - #1937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Prod deploys have been failing all day since the wave-7 chains merge. The sitemap smoke gate finds 6 chain URLs returning 404:
These chains exist in CHAINS but have no associated bench data. Normally
getBenchmarksForChainreturns [] and they're filtered out (return null). But when an exception is thrown during the build (e.g. KV store cold-start timeout), the catch block was blindly emitting all chain slugs, including ones with no benches. The deployed page then correctly 404s, failing the smoke gate and rolling back every prod deploy.Fix
Change the catch block to return null (fail-safe) instead of emitting an unverified URL. Chains with real bench data re-enter the sitemap on the next successful build.