Skip to content

🧪 Add missing edge case tests for serve.py record_line #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ch3fUlrich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧪 Add missing edge case tests for serve.py record_line #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/test-process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,26 @@ def test_server_counts_completion_not_started_lines(self):
server.record_line('@@AUTOOS_PROGRESS {"done":4,"total":3}')
self.assertEqual(server.RUN['done'], 1)

def test_record_line_edge_cases(self):
server = load('autoos_serve', 'lib/linux/serve.py')
server.RUN.update(done=0, total=3, current=None)
server.LOG.clear()

cases = [
'@@AUTOOS_PROGRESS {broken', # json.JSONDecodeError (ValueError)
'@@AUTOOS_PROGRESS "string"', # TypeError (when int() fails on dict lookup)
'@@AUTOOS_PROGRESS {"done": "x"}', # KeyError (missing total) / ValueError (int("x"))
'@@AUTOOS_PROGRESS {"total": 3}', # KeyError (missing done)
'@@AUTOOS_PROGRESS {"done": -1, "total": 3}', # Out of bounds: done < 0
'@@AUTOOS_PROGRESS {"done": 4, "total": 3}', # Out of bounds: done > total
'@@AUTOOS_PROGRESS {"done": 1}', # KeyError (missing total)
]

for case in cases:
server.record_line(case)
self.assertEqual(server.RUN['done'], 0)
self.assertEqual(len(server.LOG), 0)

def test_unknown_percentage_stays_null(self):
runner = load('autoos_process', 'lib/linux/process.py')
output = io.StringIO()
Expand Down
Loading