Conversation
…ing-#121 Dynamic fuel switching #121
…port-feature-#176 feat: add metadata export v1
…ion-table-updates feat: add free text search + sorting to load selection table
…ironment/decarb-tool into additional-refrigerant-equipment
…ssions-factors-#52 Average emissions factors #52
…-PR#180 fix: minor adjustments to PR #180
…minor-fixes-PR#180 Revert "fix: minor adjustments to PR #180"
…average-emissions-factors-#52 Revert "Average emissions factors #52"
…revert-180-average-emissions-factors-#52 Revert "Revert "Average emissions factors #52""
…-trigger-behavior Update calc trigger behavior
…ntation-link fix: move up Docs link in sidebar
First pass at tooltips #167
…refrigerant-equipment Additional refrigerant equipment
…-scenarios-displayed-#188 fix: address #188, adjust scen ordering
build_metadata_summary() (added in #178, metadata-export-feature-#176) accessed scen.shortrun_weighting directly, but that field was removed from EmissionScenario by the average-emissions-factors-#52 work (landed via #180, reverted/re-landed through #181-#184). The two PRs never touched each other's files, so the export code was left referencing a field that no longer exists. Since EmissionScenario is a Pydantic model, the missing attribute raised AttributeError instead of returning None, and that exception was silently swallowed by the broad except/pass in _add_metadata_files() (pages/results_page.py) — so settings_summary.txt and settings.json quietly stopped being included in the results download zip, with no visible error. Refs #176 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
|
Fixed this with #194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a leftover reference to the short/long run weighting (that we removed entirely) and was causing the whole export to drop out from the download