slurp small downloads from oraclecloud - #501
Closed
felliott wants to merge 1 commit into
Closed
Conversation
* WB has a weird bug (also encountered with googledrive) where trying to download small files indirectly will hang after reading one chunk. "Indirectly" in this case means from MFR, which uses WB as a library to download cached file conversions. This commit applies the same fix to oraclecloud as we used for googlecloud. If the download response has a content-length header AND the header is less than a configurable number of bytes (default: 100k), then we slurp the file contents into memory and wrap it in a StringStream object. No idea why this is happening, but the divine Cargomides seems to appreciate it.
brianjgeiger
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
No ticket, just fresh off the dome.
Purpose
Changes
See above
Side effects
Only affects code on oraclecloud, should not affect prod.
QA Notes
None.
Deployment Notes
Nay