Various implimentations and fixes#1
Open
CatoChristopherMrow wants to merge 44 commits into
Open
Conversation
impliments proc/Export proc/MeasureText proc/Crop proc/DrawBox proc/Flip proc/GetPixel proc/MapColors proc/SetIntensity proc/Shift proc/SwapColor proc/Turn proc/Find_char proc/Replace_char
Preserve modified type constant var overrides through dynamic new path Implement/wire native shell(), run(), world.OpenPort(), and walk_away() Implement /matrix.Interpolate() and undocumented matrix(..., MATRIX_INTERPOLATE) Support set src = usr.loc verb accessibility Add operator"" string interpolation support Add focused DM tests for modified type constants, matrix interpolation, shell/run/OpenPort, and stringify overloads
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| private readonly delegate*<Bundle, DreamObject?, DreamObject?, DreamValue> _handler; | ||
|
|
||
| public NativeProc(int id, TreeEntry owningType, string name, List<string> argumentNames, Dictionary<string, DreamValue> defaultArgumentValues, HandlerFn handler, DreamManager dreamManager, DreamRefManager refManager, AtomManager atomManager, IDreamMapManager mapManager, DreamResourceManager resourceManager, WalkManager walkManager, DreamObjectTree objectTree) | ||
| public NativeProc(int id, TreeEntry owningType, string name, List<string> argumentNames, Dictionary<string, DreamValue>? defaultArgumentValues, HandlerFn handler, DreamManager dreamManager, DreamRefManager refManager, AtomManager atomManager, IDreamMapManager mapManager, DreamResourceManager resourceManager, WalkManager walkManager, DreamObjectTree objectTree) |
| using Robust.Client.UserInterface; | ||
| using Robust.Client.UserInterface.Controls; | ||
| using Robust.Client.UserInterface.CustomControls; | ||
| using Robust.Shared.Maths; |
| value = new DMFPropertySize(_window.Size); | ||
| return true; | ||
| case "is-visible": | ||
| value = new DMFPropertyBool(_window.Visible && _window.IsOpen); |
| foreach (var wingetting in properties) { | ||
| if (jsonBuilder.Length > 2) | ||
| jsonBuilder.Append(", "); | ||
| if (properties.Length == 1 && properties[0] == "*") { |
…tions2 # Conflicts: # OpenDreamClient/Interface/DreamInterfaceManager.cs
| using Robust.Client.UserInterface.Controls; | ||
| using Robust.Client.UserInterface.CustomControls; | ||
| using Robust.Shared.Maths; | ||
| using System.Numerics; |
| if(center.TryGetVariable("contents", out var centerContents) && centerContents.TryGetValueAsDreamList(out var centerContentsList)) { | ||
| foreach(DreamValue content in centerContentsList.EnumerateValues()) { | ||
| rangeList.AddValue(content); | ||
| if (content.TryGetValueAsDreamObject<DreamObjectAtom>(out var contentAtom) && contentAtom is not null) |
| if (contents.TryGetValueAsDreamList(out var locContentsList)) { | ||
| foreach (DreamValue content in locContentsList.EnumerateValues()) { | ||
| rangeList.AddValue(content); | ||
| if (content.TryGetValueAsDreamObject<DreamObjectAtom>(out var contentAtom) && contentAtom is not null) |
| AddVisibleAtom(turf); | ||
| foreach (DreamValue content in turf.Contents.EnumerateValues()) { | ||
| rangeList.AddValue(content); | ||
| if (content.TryGetValueAsDreamObject<DreamObjectAtom>(out var contentAtom) && contentAtom is not null) |
| using OpenDreamRuntime.Procs.DebugAdapter; | ||
| using OpenDreamRuntime.Resources; | ||
| using OpenDreamShared.Dream; | ||
| using Robust.Shared.Log; |
| } | ||
|
|
||
| public static DreamValue CaptureGroupToDreamValue(Group group) { | ||
| return group.Success && group.Length > 0 ? new DreamValue(group.Value) : DreamValue.Null; |
There was a problem hiding this comment.
InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.