Add dark mode #7#17
Conversation
| --radius-card: 0.75rem; | ||
| } | ||
|
|
||
| /* Dark Mode, may need to adjust as see fit */ |
There was a problem hiding this comment.
Good start! I do think some of the colors could be slightly different. While looking at the changes, what I notice is the main primary text might feel a bit too bright, and the secondary text and red text may be a little too dim against the dark background.
Also, the gap between the canvas and surface blacks can potentially be a bit wider so they pop more.
I'd try playing around with the hex codes a bit more (let me know if I can clarify my thoughts here more since they may be a bit vague)
| --radius-card: 0.75rem; | ||
| } | ||
|
|
||
| /* Dark Mode, may need to adjust as see fit */ |
There was a problem hiding this comment.
This comment can probably just be "Dark mode token overrides"
| @@ -1,4 +1,5 @@ | |||
| @import 'tailwindcss'; | |||
| @custom-variant dark (&:where(.dark, .dark *)); /* May break, unrecognized rule */ | |||
There was a problem hiding this comment.
The comment here seems unnecessary, could remove it or change to something like "dark mode rule" - seems to be a valid tailwind rule and the linting/formatting checks don't flag anything weird here
| const path = Astro.url.pathname; | ||
| --- | ||
|
|
||
| <!-- Import Lucide Icons --> |
There was a problem hiding this comment.
The comment may be misplaced slightly? Could go near the import line or where the icons are used
2 participants
No description provided.