CP-14829 - Patch critical image-upload security vulnerability - #83
Merged
Conversation
What DocuSeal now runs a patched Rails release and blocks unsafe image processing so crafted uploads cannot read server files or secrets. Why CVE-2026-66066 is a critical Active Storage / libvips issue. Submitters can upload images without auth, so production was exposed until patched. How to test 1. Confirm Gemfile.lock has rails/activestorage 8.0.5.1 2. Boot the app and complete a signing flow (signature PNG/JPEG, optional stamp) 3. Confirm template preview and completed result PDF still generate 4. Deploy staging, re-check a full e2e sign → complete, then deploy production
spaulsandhu
reviewed
Aug 2, 2026
| if defined?(Vips) && Vips.respond_to?(:block_untrusted) | ||
| Vips.block_untrusted(true) | ||
| else | ||
| warn 'WARNING: Vips.block_untrusted unavailable (libvips < 8.13?) — CVE-2026-66066 mitigation NOT active' |
Member
There was a problem hiding this comment.
Should we raise an Airbrake for this so it's super noisy vs just casually logged?
Collaborator
Author
There was a problem hiding this comment.
Good idea!
spaulsandhu
approved these changes
Aug 2, 2026
spaulsandhu
left a comment
spaulsandhu
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for jumping on this, one comment about the way we're logging this otherwise, good to go.
I'd make sure to get the 👍🏽 from @ehourigan before merging though ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP-14829
What
DocuSeal now runs a patched Rails release and blocks unsafe image processing so crafted uploads cannot read server files or secrets.
Why
CVE-2026-66066 is a critical Active Storage / libvips issue. Submitters can upload images without auth, so production was exposed until patched.
How to test