Repository navigation
ci(verify): export real-capture Studio recordings and check them against their tracks; fix audio late in exports of never-opened camera projects - #2690
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…port is missing from its audio
|
@greptileai review |
|
@greptileai review |
…r contract gives it
|
@greptileai review |
|
@greptileai review |
…previous picture may first show at any of its labels
|
Blacksmith macOS 26 flagged 13 pictures in |
|
hey @greptileai, please re-review the PR |
Behavior
The real-capture suite now exports each non-crash Studio recording and checks the export against that recording's source tracks. It verifies that required screen pictures remain present, appear on the decoder's expected frame grid, and that microphone markers remain present and within 5 ms of their recorded times.
This also fixes exports of camera recordings that have never been opened in the editor. Those projects can have no saved clip offsets.
ExporterBasenow fills them with the same initial configuration the editor uses, while preserving any offsets already saved. In the measured failing recording, all 59 microphone markers were 169.5 ms late before the fix and aligned after it.Exact timing checks
The oracle independently models request rounding, source frame labels, and track offsets. When consecutive pictures share a frame label, the previous picture can occupy that cache slot; the new picture must appear at its first label or the immediately following request. That next request need not correspond to a source sample. Later source labels do not justify a later first appearance.
A marker-index lookup avoids repeatedly scanning all earlier pictures during long soaks. Grouping 54,000 decoded samples from 27,000 distinct pictures took 10.2 ms locally; twice that input took 16.0 ms.
Validation
cargo fmt --all,cargo check -p cap-verify, strict Clippy, 12 recording unit tests, 10 verifier library tests, and 45 exporter library tests pass locally.studio-camera/startup-drops,studio-camera/long, andstudio-screen/late-mic: zero missing required pictures in all three and microphone markers aligned to the recorded times.006ec61e4at 5/5 with all review threads resolved.The marker-detector prerequisite, #2694, is merged.


Confidence Score: 5/5
The PR appears safe to merge; no new actionable issue was established.Summary
This PR checks finished Studio exports against their recorded screen pictures and microphone markers. It also fixes audio timing when a camera project has never been opened in the editor.
The previous threads were rechecked. Missing microphone markers inside the checked range are reported, request rounding follows the decoder’s rule, and picture lookups no longer scan every earlier picture. None of the supplied threads has a Comment number, so
previousFindingsis empty.Review was based on code inspection. No builds or tests were run.
Reviews (7) · Last reviewed commit: "chore: merge marker detection fix for ex..." · Reviewed by Greptile