test(recorder-core): add test coverage for detectRecordingModeFromTrack - #2159
Open
gcoinstash-cmd wants to merge 3 commits into
Open
test(recorder-core): add test coverage for detectRecordingModeFromTrack#2159gcoinstash-cmd wants to merge 3 commits into
gcoinstash-cmd wants to merge 3 commits into
Conversation
Manage your Superagent protectionSuperagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans. You have 0 of 3 included PR scans remaining. Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected. |
| }); | ||
| }); | ||
|
|
||
| it("throws error when session description is null or undefined", async () => { |
Contributor
There was a problem hiding this comment.
Test title overstates coverage
The test claims to cover both null and undefined, but its only invocation passes null; this makes the suite report an invalid-input case as covered when it is not exercised.
Suggested change
| it("throws error when session description is null or undefined", async () => { | |
| it("throws error when session description is null", async () => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 68
Comment:
**Test title overstates coverage**
The test claims to cover both `null` and `undefined`, but its only invocation passes `null`; this makes the suite report an invalid-input case as covered when it is not exercised.
```suggestion
it("throws error when session description is null", async () => {
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
packages/recorder-core/__tests__/recorder-utils.test.tsfordetectRecordingModeFromTrack.nullinput tracks and validates track label parsing heuristics across fullscreen, application window, and browser tab captures.Test Validation
pnpm --filter=@cap/recorder-core test: 67/67 unit tests passed 100% green in 1.51s.Greptile Summary
This PR expands unit coverage for recording-mode detection and WebRTC session-description conversion.
Confidence Score: 4/5
The PR appears safe to merge, with only a non-blocking inaccurate test description.
The added tests do not change production behavior; the only accepted concern is that one test name overstates the invalid-input cases it exercises.
Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "test(recorder-core): add test coverage f..." | Re-trigger Greptile