test(chrome-extension): add unit test coverage for toSessionDescriptionInit - #2158
Open
gcoinstash-cmd wants to merge 1 commit into
Open
test(chrome-extension): add unit test coverage for toSessionDescriptionInit#2158gcoinstash-cmd wants to merge 1 commit into
gcoinstash-cmd wants to merge 1 commit into
Conversation
Manage your Superagent protectionSuperagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans. You have 0 of 3 included PR scans remaining. Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected. |
| }); | ||
| }); | ||
|
|
||
| it("throws error when session description is null or undefined", async () => { |
Contributor
There was a problem hiding this comment.
This test names both null and undefined, but its only assertion passes null, so the suite reports explicit undefined coverage that it does not provide.
Suggested change
| it("throws error when session description is null or undefined", async () => { | |
| it("throws error when session description is null", async () => { |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/chrome-extension/src/shared/webrtc.test.ts
Line: 68
Comment:
**Test name overstates coverage**
This test names both `null` and `undefined`, but its only assertion passes `null`, so the suite reports explicit `undefined` coverage that it does not provide.
```suggestion
it("throws error when session description is null", async () => {
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
toSessionDescriptionInitinapps/chrome-extension/src/shared/webrtc.test.ts.RTCSessionDescriptionpayloads correctly format intoRTCSessionDescriptionInitobjects and missing descriptions throw informative errors.Test Validation
pnpm --filter=@cap/chrome-extension test: 20/20 unit tests passed 100% green.Greptile Summary
Adds focused unit coverage for converting WebRTC session descriptions and rejecting missing descriptions.
Confidence Score: 4/5
The PR appears safe to merge, with only a non-blocking mismatch between one test’s description and the input it exercises.
The new tests cover the intended conversion and null-error behavior, but the “null or undefined” case only invokes null and should either add an undefined assertion or narrow its name.
Files Needing Attention: apps/chrome-extension/src/shared/webrtc.test.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "test(chrome-extension): add unit test co..." | Re-trigger Greptile