You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Converted all Capgo CLI Zod schemas under cli/src/schemas/ to ArkType, matching the backend validation stack
Upgraded MCP from @modelcontextprotocol/sdk v1 to @modelcontextprotocol/server v2 beta so tools can register ArkType/Standard Schema inputSchema directly
Removed direct zod dependencies from root and CLI package.json (Zod may still appear transitively via MCP/knip)
Motivation (AI generated)
Backend validation already standardized on ArkType + Standard Schema. Keeping Zod only in the CLI duplicated dependencies and patterns. MCP SDK v2 accepts ArkType natively, so we can drop Zod from our direct dependency tree.
Business Impact (AI generated)
Smaller/simpler CLI dependency surface and one validation library across Capgo backend + CLI. MCP tool schemas stay LLM-friendly via ArkType .describe() metadata. Note: MCP server package is currently on a beta release.
Unify CLI schemas on ArkType (already used by the backend) and upgrade
the MCP server to the v2 beta Standard Schema API so Zod can be dropped
as a direct dependency.
Co-authored-by: Cursor <cursoragent@cursor.com>
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
▶️ Resume reviews
🔍 Trigger review
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 4f5f6f7f-a667-43b4-8e4b-1324cab2e3c6
📥 Commits
Reviewing files that changed from the base of the PR and between 41e04fe and 5ccaa93.
⛔ Files ignored due to path filters (1)
bun.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
cli/package.json
cli/src/utils.ts
package.json
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Cap-go/capacitor-updater(manual)
📝 Walkthrough
Walkthrough
The CLI migrates runtime schemas from Zod to ArkType, adds Standard Schema parsing helpers, and updates MCP tooling from server.tool to server.registerTool with centralized input schemas. Dependencies, server wiring, and related tests are updated.
Changes
ArkType validation and domain schemas
Layer / File(s)
Summary
Validation foundation and dependencies cli/package.json, package.json, cli/src/schemas/ark_validation.ts, cli/src/schemas/validate.ts, cli/src/utils.ts
Adds Standard Schema parsing utilities, removes Zod dependencies, and updates validation consumers to use safeParseSchema and parseSchema.
Domain schema migration cli/src/schemas/*.ts
Rewrites application, build, bundle, channel, organization, SDK, onboarding, authentication, and shared schemas with ArkType while updating inferred types and cross-field validation.
MCP registration migration
Layer / File(s)
Summary
MCP schema and registration migration cli/src/mcp/*, cli/src/build/onboarding/mcp/*, cli/src/init/mcp/*
Adds shared MCP input schemas, introduces McpRegistrar, and converts tool registration and tracking to registerTool.
Cap-go/capgo.app#2684: Updates overlapping MCP server and live-update schema integration points.
Suggested labels:codex
Suggested reviewers:wcaleniewolny
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 35.71% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title accurately summarizes the main change: replacing Zod with ArkType across the CLI.
Description check
✅ Passed
The description covers summary and test plan well, but it omits the template's Screenshots and Checklist sections.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches📝 Generate docstrings
Create stacked PR
Commit on current branch
Warning
There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.
🔧 Checkov (3.3.8)cli/package.json
Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'
package.json
Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'
Comment @coderabbitai help to get the list of available commands.
Update CLI MCP tests to @modelcontextprotocol/client, trim unused
ark_validation/config exports so knip passes, and keep only live types.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), so I am not approving. Human review is needed for this CLI Zod→ArkType validation refactor; WcaleNieWolny assigned as reviewer.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), and this broad CLI Zod→ArkType validation refactor exceeds the low-risk approval threshold. Not approving; WcaleNieWolny is already assigned for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
The reason will be displayed to describe this comment to others. Learn more.
All reported issues were addressed across 36 files
Confidence score: 5/5
Safe to merge after the addressed issues were fixed.
Tip: instead of fixing issues one by one fix them all with cubic Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Register prompts via registerPrompt, strip undeclared keys with ArkType
'+': 'delete', allow optional undefined, and add toJsonSchema fallback so
tools/list works with MCP Standard Schema export.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), and this broad CLI Zod→ArkType validation refactor exceeds the low-risk approval threshold. Not approving; WcaleNieWolny is already assigned for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), so I am not approving. WcaleNieWolny is already assigned for human review of this CLI Zod→ArkType validation refactor.
Sent by Cursor Approval Agent: Pull Request Approver
Document why capgo_update_channel uses two schemas.
The advertised inputSchema (mcpUpdateChannelInputSchema) omits the mutual-exclusivity checks that updateChannelOptionsSchema.narrow(...) enforces (e.g. rolloutEnable/rolloutDisable, the rolloutPause/rolloutResume/rolloutRollback/rolloutPromote group, autoPauseEnabled/autoPauseDisabled), which is why parseSchema(updateChannelOptionsSchema, ...) re-validates inside the handler. This split is very likely required because ArkType .narrow() predicates aren't convertible to JSON Schema, so updateChannelOptionsSchema itself can't be used as the wire-facing inputSchema. Worth a short comment here (or at the two schema definitions) explaining that rationale, since it's easy for a future reader to "simplify" by collapsing the two schemas and unknowingly break tool registration or silently drop the narrow constraints.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cli/src/mcp/server.ts` around lines 429 - 478, Document the intentional
two-schema flow in capgo_update_channel: add a brief comment explaining that
mcpUpdateChannelInputSchema is used for wire-facing tool registration because
ArkType narrow predicates cannot be converted to JSON Schema, while
parseSchema(updateChannelOptionsSchema, ...) revalidates the mutual-exclusivity
constraints inside the handler. Keep both schemas and the existing validation
behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/src/mcp/tool-schemas.ts`:
- Around line 4-8: Update the bare fields in mcpAddAppInputSchema,
mcpUpdateAppInputSchema, mcpUploadBundleInputSchema,
mcpCleanupBundlesInputSchema, mcpGetStatsInputSchema,
mcpRequestBuildInputSchema, and the applicable fields of
mcpUpdateChannelInputSchema to use ArkType .describe() metadata, matching the
descriptive style of the already-documented schemas in this file. Add clear
descriptions for fields including rollout, force, nodeModules, and all
rollout/auto-pause flags without changing validation behavior.
In `@cli/src/schemas/validate.ts`:
- Around line 15-16: Factor out a shared Standard Schema path formatter that
converts `{ key }` segments to their keys, joins segments with dots, and returns
“value” for empty paths. Replace the direct path joining in
cli/src/schemas/validate.ts:15-16 and cli/src/utils.ts:2088-2090 with this
formatter; both sites require the change.
In `@cli/test/test-mcp-live-update-onboarding.mjs`:
- Around line 156-162: Update the schema validation assertions in the onboarding
test to parse the `inputSchema` captured from each registered tool in
`server.tools`, rather than the imported schema constants. Apply this to the
affected assertions around `capgo_live_update_onboarding_explain` and the
additional locations noted by the review, preserving the existing valid and
invalid fixture expectations.
---
Outside diff comments:
In `@cli/src/mcp/server.ts`:
- Around line 429-478: Document the intentional two-schema flow in
capgo_update_channel: add a brief comment explaining that
mcpUpdateChannelInputSchema is used for wire-facing tool registration because
ArkType narrow predicates cannot be converted to JSON Schema, while
parseSchema(updateChannelOptionsSchema, ...) revalidates the mutual-exclusivity
constraints inside the handler. Keep both schemas and the existing validation
behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f709bddf-7d74-43a4-a0b7-e9d2d4503270
📥 Commits
Reviewing files that changed from the base of the PR and between c1f6aa5 and 4e56ca9.
Factor out shared MCP schema fragments.
These MCP inputs are intentional subsets of the SDK options, but the shared bounds and field shapes still live in two places. Reuse common fragments from cli/src/schemas/sdk.ts where possible to keep MCP and SDK validation from drifting.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cli/src/mcp/tool-schemas.ts` around lines 4 - 167, Refactor the MCP schemas
in the exported mcp*InputSchema definitions to reuse applicable shared field
fragments and bounds from cli/src/schemas/sdk.ts instead of duplicating them
locally. Prioritize overlapping options such as rollout, retention, auto-pause,
and Capacitor configuration while preserving each MCP schema’s intentional
subset and existing validation behavior.
Source: Coding guidelines
cli/src/schemas/channel.ts (1)
9-26: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
Do not narrow the public version field without a compatibility plan.
The schema now accepts only an optional object-shaped version, whereas the previous contract accepted any optional value. Existing API responses containing a scalar, array, null, or another valid legacy format will now fail parsing. Preserve the broad field shape, or gate the stricter object form by API/plugin version and add regression coverage.
As per coding guidelines, public APIs and plugin interfaces must remain backward compatible; do not change existing fields, meanings, formats, or status codes.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cli/src/schemas/channel.ts` around lines 9 - 26, Update the version field in
channelSchema to preserve the previous broad optional-value contract instead of
requiring an object shape. Keep Channel inference compatible with scalar, array,
null, and other legacy version values, and do not narrow the public API field
without version gating.
Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/src/schemas/arktype_config.ts`:
- Around line 5-10: Update the ArkType JSON Schema configuration in configure so
fallback.default only returns ctx.base for unsupported optional-undefined cases;
make all other unsupported nodes throw or otherwise fail explicitly. Preserve
narrow constraints used by the channel and SDK schemas instead of silently
dropping them.
---
Outside diff comments:
In `@cli/src/mcp/tool-schemas.ts`:
- Around line 4-167: Refactor the MCP schemas in the exported mcp*InputSchema
definitions to reuse applicable shared field fragments and bounds from
cli/src/schemas/sdk.ts instead of duplicating them locally. Prioritize
overlapping options such as rollout, retention, auto-pause, and Capacitor
configuration while preserving each MCP schema’s intentional subset and existing
validation behavior.
In `@cli/src/schemas/channel.ts`:
- Around line 9-26: Update the version field in channelSchema to preserve the
previous broad optional-value contract instead of requiring an object shape.
Keep Channel inference compatible with scalar, array, null, and other legacy
version values, and do not narrow the public API field without version gating.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d1d70b95-8b10-43f1-8979-742470c8c909
📥 Commits
Reviewing files that changed from the base of the PR and between 4e56ca9 and 4f8c5dc.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Use a unit-only toJsonSchema fallback for optional undefined, prefer
ArkType problem text in validateOptions, and trim/reject blank locale
keys for localized store release notes.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), and this broad CLI Zod→ArkType validation refactor exceeds the low-risk approval threshold. Not approving; WcaleNieWolny is already assigned for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), so I am not approving. WcaleNieWolny is already assigned for human review of this CLI Zod→ArkType validation refactor.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cli/src/schemas/build.ts`:
- Around line 4-18: Reject duplicate locale keys after trimming in the localized
release-notes validation: in cli/src/schemas/build.ts lines 4-18, check
Object.hasOwn(out, key) before assigning out[key] and reject duplicates; apply
the same validation in cli/src/schemas/sdk.ts lines 21-35. Preserve the existing
non-empty key and value checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
Push a commit to this branch (recommended)
Create a new PR with the fixes
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b681ee39-87b9-4536-b8df-8b4f06d30a62
📥 Commits
Reviewing files that changed from the base of the PR and between 4f8c5dc and 8e17a4f.
📒 Files selected for processing (4)
cli/src/schemas/arktype_config.ts
cli/src/schemas/build.ts
cli/src/schemas/sdk.ts
cli/src/schemas/validate.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Share one null-prototype locale-notes schema that rejects blank/duplicate
keys, keep paths on ArkType problems, and throw a typed error for
unsupported JSON Schema units.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), so I am not approving. WcaleNieWolny is already assigned for human review of this CLI Zod→ArkType validation refactor.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), and this broad CLI Zod→ArkType validation refactor exceeds the low-risk approval threshold. Not approving; WcaleNieWolny is already assigned for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
Require a plain object for localized release notes, and always prefix
ArkType problems with the issue path in validateOptions.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), and this broad CLI Zod→ArkType validation refactor exceeds the low-risk approval threshold. Not approving; WcaleNieWolny is already assigned for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Stale comment
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), so I am not approving. WcaleNieWolny is already assigned for human review of this CLI Zod→ArkType validation refactor.
Sent by Cursor Approval Agent: Pull Request Approver
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
cli/src/schemas/index.ts (1)
68-69: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Restore the removed config-schema exports.
Removing capacitorConfigSchema and extConfigPairsSchema breaks existing imports from this public barrel. Re-export both schemas alongside their types.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@cli/src/schemas/index.ts` around lines 68 - 69, Update the Config exports in
the public schema barrel to re-export capacitorConfigSchema and
extConfigPairsSchema alongside CapacitorConfig and ExtConfigPairs, preserving
existing imports.
Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@cli/src/schemas/index.ts`:
- Around line 68-69: Update the Config exports in the public schema barrel to
re-export capacitorConfigSchema and extConfigPairsSchema alongside
CapacitorConfig and ExtConfigPairs, preserving existing imports.
ℹ️ Review info⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8cea7b03-7b48-4ae2-8345-0abd4c1385ce
📥 Commits
Reviewing files that changed from the base of the PR and between 8e17a4f and 41e04fe.
📒 Files selected for processing (6)
cli/src/schemas/arktype_config.ts
cli/src/schemas/build.ts
cli/src/schemas/common.ts
cli/src/schemas/index.ts
cli/src/schemas/sdk.ts
cli/src/schemas/validate.ts
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Resolve cli/package.json and bun.lock conflicts while keeping ArkType +
MCP v2 and main dependency bumps.
Co-authored-by: Cursor <cursoragent@cursor.com>
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), and this broad CLI Zod→ArkType validation refactor exceeds the low-risk approval threshold. Not approving; WcaleNieWolny is already assigned for human review.
Sent by Cursor Approval Agent: Pull Request Approver External
The reason will be displayed to describe this comment to others. Learn more.
Risk: medium. Cursor Bugbot did not complete (check skipped — usage limit reached), so I am not approving. WcaleNieWolny is already assigned for human review of this CLI Zod→ArkType validation refactor.
Sent by Cursor Approval Agent: Pull Request Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary (AI generated)
cli/src/schemas/to ArkType, matching the backend validation stack@modelcontextprotocol/sdkv1 to@modelcontextprotocol/serverv2 beta so tools can register ArkType/Standard SchemainputSchemadirectlyzoddependencies from root and CLIpackage.json(Zod may still appear transitively via MCP/knip)Motivation (AI generated)
Backend validation already standardized on ArkType + Standard Schema. Keeping Zod only in the CLI duplicated dependencies and patterns. MCP SDK v2 accepts ArkType natively, so we can drop Zod from our direct dependency tree.
Business Impact (AI generated)
Smaller/simpler CLI dependency surface and one validation library across Capgo backend + CLI. MCP tool schemas stay LLM-friendly via ArkType
.describe()metadata. Note: MCP server package is currently on a beta release.Test Plan (AI generated)
bun run cli:lintbun run cli:typecheckbun run cli:buildtest-upload-validation,test-mcp-live-update-onboarding,test-mcp-onboarding,test-mcp-build-tools,test-mcp-credentials-manage,test-mcp-oauth-reopen,test:mcp)Generated with AI
Made with Cursor
Summary by CodeRabbit