chore: sync upstream PR #8473 - fix(runtime): plugin proxy must not be unintentionally Thenable

[riderx]

Merge Conflict Review Required

The sync of upstream PR ionic-team#8473 from @playopsstudio encountered merge conflicts.

Original PR: ionic-team#8473

What happened

• Git applied the upstream-preferred merge strategy
• This PR requires CI and manual review before merging

---

Synced from upstream by Capacitor+ Bot

[riderx]

Git applied the upstream-preferred strategy to resolve this sync. Please review the branch carefully before merging.

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5c35254b-3661-443a-a278-cd50ebb21e52

📥 Commits

Reviewing files that changed from the base of the PR and between 56cdc94 and 7fba2c4.

📒 Files selected for processing (2)

• core/src/runtime.ts
• core/src/tests/plugin.spec.ts

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Beta npm build

Maintainers can publish one Capacitor Plus workspace package from this PR to npm for fast testing.

Comment /publish-beta <package> after the PR checks are green.

Examples:

/publish-beta core
/publish-beta cli
/publish-beta @capacitor-plus/core

If exactly one workspace package changed, /publish-beta without a package will use that package.

Packages:

• core (@capacitor-plus/core)
• cli (@capacitor-plus/cli)
• android (@capacitor-plus/android)
• ios (@capacitor-plus/ios)

The workflow will:

• publish a prerelease package on the beta tag
• add a pinned pr-88 dist-tag for the selected package
• update this comment with the install command

Security note: beta publish is only enabled for branches inside this repository.

[cursor]

Risk: medium. Not approving: this upstream core runtime sync exceeds the low-risk threshold, and the lint check failed (frozen lockfile drift). Human review is needed before merge.

  

_{Sent by Cursor Approval Agent: Pull Request Approver External}

[cursor]

Risk: medium. Not approving: lint CI failed (frozen lockfile drift) and core tests were skipped, so the runtime fix is unverified. Cursor Bugbot was not present on this PR. Human review is needed before merge.

  

_{Sent by Cursor Approval Agent: Pull Request Approver}

[cubic-dev-ai]

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="core/src/runtime.ts">

<violation number="1" location="core/src/runtime.ts:177">
P2: When a plugin defines a method named `catch` or `finally`, the proxy now returns `undefined` instead of the method wrapper, so the method is inaccessible for both JS and native implementations. Promise assimilation only reads `then`; keep only the `then` case so arbitrary plugin method names remain supported.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: When a plugin defines a method named catch or finally, the proxy now returns undefined instead of the method wrapper, so the method is inaccessible for both JS and native implementations. Promise assimilation only reads then; keep only the then case so arbitrary plugin method names remain supported.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At core/src/runtime.ts, line 177:

<comment>When a plugin defines a method named `catch` or `finally`, the proxy now returns `undefined` instead of the method wrapper, so the method is inaccessible for both JS and native implementations. Promise assimilation only reads `then`; keep only the `then` case so arbitrary plugin method names remain supported.</comment>

<file context>
@@ -173,6 +173,11 @@ export const createCapacitor = (win: WindowCapacitor): CapacitorInstance => {
             case 'removeListener':
               return removeListener;
+            // Promise-machinery short-circuit. See #8472 for failure modes.
+            case 'then':
+            case 'catch':
+            case 'finally':
</file context>

Suggested change

	case 'then':
	case 'catch':
	case 'finally':
	case 'then':