Don't panic in the cleaner when there's nothing to clean - #6
Open
nickwolf wants to merge 1 commit into
Open
Conversation
process_batch returns early on a batch of one but not on an empty one, and run_library_cleaner calls it unconditionally after the loop. With no torrents to clean the batch is empty and batch[0] panics, killing the cleaner task on startup: thread 'tokio-runtime-worker' panicked at server/src/cleaner.rs:62:13: index out of bounds: the len is 0 but the index is 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleaner task dies on startup when there's nothing to clean:
process_batchreturns early on a batch of one but not on an empty one, andrun_library_cleanercalls it unconditionally after the loop.