Floating point values and Python updates#42
Open
prkrtg wants to merge 34 commits into
Open
Conversation
…side or outside of a package verify that the old DEIMOS makefile and the new one work exactly the same
* Handle special sequence "Start" that does not require an exit. * Added comment about special Start sequence
All constants will be floats
… defs raw strings
… from 1D array to scalar in recent numpy
added 3 commits
February 27, 2026 15:28
…ES NOT WORK, silently fails to emit code when using constants in a SET statement
weatherhead99
left a comment
weatherhead99
left a comment
Contributor
There was a problem hiding this comment.
only see one minor issue.
Contributor
There was a problem hiding this comment.
this likely needs the same hack as Lexer.py and seqParserDriver.py etc,
old WDL makefiles assume you can call these directly, and also assume that they're sat directly next to top level imports of other WDL stuff. The "new" cli I wrote doesn't. So we need to support both to prevent breakage of old WDL code. I think I didn't find any instance where LexerDriver.py was actually run directly in a Makefile context but I could be wrong about that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.