Firefly-2113: Scope test suite and add React component testing - #2016
aventura121 wants to merge 19 commits into
Conversation
loitly
left a comment
There was a problem hiding this comment.
At the moment, it's only the Node version, but there may be more environment setup once we add Java unit tests. I'd suggest running the unit tests through Docker Compose. Since the build/test environment is already defined there, this keeps the environment consistent between local development and CI and avoids duplicating configuration in the GitHub Actions workflow. What do you think?
Sounds good to me, @loitly. I added a new service for it, using the same build step as the existing test job. I think this captures your idea. fyi I added a max workers param for jest because it can spawn too many workers when running locally. |
Firefly-2113: "Scope Existing Test Suite"
This PR also closes:
Description
Testing
Build: https://firefly-2113-scope-test-suite.irsakubedev.ipac.caltech.edu/firefly
In this case, the pull request here is really the validation, as there are no core application code changes. All test pass as expected, including the React component test for CloseButton.jsx.
Expand the More Actions icon below and select View Details to see the workflow's summary and details.