Skip to content

Firefly-2113: Scope test suite and add React component testing - #2016

Open
aventura121 wants to merge 19 commits into
devfrom
FIREFLY-2113-scope-test-suite
Open

aventura121 wants to merge 19 commits into
devfrom
FIREFLY-2113-scope-test-suite

Conversation

@aventura121

@aventura121 aventura121 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Firefly-2113: "Scope Existing Test Suite"

This PR also closes:

Description

  • Adds a testing workflow to the pull requests that runs the Jest tests only (and skips any firefly-test-data dependent tests).
  • This workflow cancels any pending runs as people push additional commits to their pull requests.
  • The workflow does not gate merging to dev (that is configured separately in github).
  • Updates dependencies to enable unit testing React components.
  • Adds a simple test module for CloseButton.jsx to show the React testing works.

Testing

Build: https://firefly-2113-scope-test-suite.irsakubedev.ipac.caltech.edu/firefly

In this case, the pull request here is really the validation, as there are no core application code changes. All test pass as expected, including the React component test for CloseButton.jsx.

Expand the More Actions icon below and select View Details to see the workflow's summary and details.

@aventura121 aventura121 changed the title Firefly 2113 scope test suite Firefly-2113: Scope test suite and add React component testing Sep 16, 2026
@aventura121 aventura121 self-assigned this Sep 16, 2026
@aventura121 aventura121 added this to the 2026.3 milestone Sep 16, 2026
@aventura121
aventura121 marked this pull request as ready for review September 17, 2026 13:23
@aventura121
aventura121 requested a review from loitly September 17, 2026 13:23

@loitly loitly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, it's only the Node version, but there may be more environment setup once we add Java unit tests. I'd suggest running the unit tests through Docker Compose. Since the build/test environment is already defined there, this keeps the environment consistent between local development and CI and avoids duplicating configuration in the GitHub Actions workflow. What do you think?

@aventura121 aventura121 added Infrastructure multi-ticket This PR implements multiple Jira tickets and removed enhancement labels Sep 17, 2026
@aventura121

Copy link
Copy Markdown
Contributor Author

At the moment, it's only the Node version, but there may be more environment setup once we add Java unit tests. I'd suggest running the unit tests through Docker Compose. Since the build/test environment is already defined there, this keeps the environment consistent between local development and CI and avoids duplicating configuration in the GitHub Actions workflow. What do you think?

Sounds good to me, @loitly. I added a new service for it, using the same build step as the existing test job. I think this captures your idea. fyi I added a max workers param for jest because it can spawn too many workers when running locally.

@aventura121
aventura121 requested a review from loitly September 17, 2026 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure multi-ticket This PR implements multiple Jira tickets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants