Conversation
dae79ec to
4a2b465
Compare
- add to build_publis an option make only standalone - get_firefly now has a development mode to pull from a branch build - more checking after each download - java install less fragile - documenation has better trouble shooting - fallback clean up of redis - fix a couple of bug
4a2b465 to
4540cba
Compare
loitly
left a comment
There was a problem hiding this comment.
I tested the instructions and they worked great. I found a bug, and have a few comments:
ff status
- Report on the wrong port
$ ff start --port 9999
$ ff status
The Firefly server is not running- Additional information would be nice, e.g.
Firefly server: running and healthy (pid 48213)
URL: http://localhost:10233/firefly/
Ports: firefly 10233, redis 10234, debug 5005 (suspend=y)
Version: 2026.2.1
Work dir: ~/.firefly/server/workarea
Logs dir: ~/.firefly/server/logs - Or, keep status simple but add an
infocommand to show full dump
Install
There a long pause(> 30s) after I enter the suggested command. Why?
curl -L https://raw.githubusercontent......
- It allow me to install on top of an existing install_dir. Does it cleanly write over it? Will it properly update a later version of JRE, for example?
Please fix typo and ff status bug.
| public static boolean isNewVersionAvailable(String currVer, String availableVer) { | ||
| if (currVer==null) currVer= "0,0.0"; | ||
| if (currVer==null) currVer= "0.0.0"; | ||
| if (availableVer==null) availableVer= "0,0.0"; |
There was a problem hiding this comment.
The typo 0,0.0 is fixed in the first instance, but not in the second.
|
I had fixed the status bug. Maybe I forgot to rebuild. I will do it again. |
|
I can add more status as well |
- added more status information - added same status information in the about dialog
|
@loitly I did your suggested updates on the the status and the about. Try it again, the build is ready. |
|
I also mentioned what appeared to be 'stuck' when running the suggested install command. I traced it down to + curl -fsSL https://nightly.link/Caltech-IPAC/firefly/actions/runs/35140976592/standalone-zip.zip -o /var/folders/c0/1t8k80r13b3dw3n6y7l966000000gp/T/firefly-build-artifact.XXXXXX.CymFcfR5fLI think it should use some progress printouts so that it does not appear to be stalled. Maybe add curl -L https://raw.githubusercontent.com/Caltech-IPAC/firefly/refs/heads/FIREFLY-2099-stand-hard/bin/get-firefly | FIREFLY_BRANCH=FIREFLY-2099-stand-hard bash
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3495 100 3495 0 0 257k 0 --:--:-- --:--:-- --:--:-- 262k
|
|
I did not do that because this is only for the testing branch. I can in the future but the end-user will not see it, but I will take out the did it work for you? |
Yes, the update status output looks great. However, it's still not picking up the right pid when using a different port. But, you said it should be fixed already. $ ff start --port 9999
Firefly server starting in background (it takes a few seconds)...
---------------------------------
Firefly URL: http://localhost:9999/firefly/
---------------------------------
Firefly server waiting for init to complete...Ready
to stop server: firefly/bin/ff stop
$ ff status
The Firefly server is not running |
|
i missed what you were doing (--port 9999). There had been another bug I fixed before it was out for review. I thought is was a regression issue. I don't think I actually save the port when it is overridden like that. Let me look at that. |
|
@loitly - ok, I think I have it fixed now. If the first install line does not work the use the second. The first only works if in ops we pull from from the release asset. |
Firefly-2099: Harden and improve Firefly standalone install
build_publishan option make only standalone.zipget_fireflynow has a development mode to pull from a branch buildTesting
get_fireflyin branch testing mode. This command should be from a bash promptcurl -L https://raw.githubusercontent.com/Caltech-IPAC/firefly/refs/heads/FIREFLY-2099-stand-hard/bin/get-firefly | FIREFLY_BRANCH=FIREFLY-2099-stand-hard bashff startff statusff logs -fff stopff status(again)ff uninstallAlternate which to do test install
get_fireflyrequiresjqbe installed. If you don't have it (which jq) then you will need to us this command which defines the github run id directlycurl -L https://raw.githubusercontent.com/Caltech-IPAC/firefly/refs/heads/FIREFLY-2099-stand-hard/bin/get-firefly | FIREFLY_BRANCH=FIREFLY-2099-stand-hard FIREFLY_RUN_ID=35272093406 bash