Refactor plugin from trait to AdapterFactory and add adapter for GCS and R2 - #8
Merged
Merged
Conversation
flohdez
changed the title
steinkel
requested changes
May 25, 2026
steinkel
left a comment
steinkel
left a comment
Member
There was a problem hiding this comment.
⚠️ Failing Unit Tests (confirmed locally)
Running vendor/bin/phpunit on this branch produces 7 errors, 9 passing:
5 × GcsAdapterTest — all fail with:
PHPUnit\Framework\MockObject\Generator\UnknownTypeException:
Class or interface "Google\Cloud\Storage\StorageObject" does not exist
google/cloud-storage is only in suggest, not require-dev, so SDK classes are unavailable after a plain composer install. Fix: move it to require-dev.
2 × R2AdapterTest — testCreatePresignedRequestReturnsPsrRequest and testPresignedUrlReturnsString fail with:
TypeError: Aws\S3\S3Client::__construct(): Argument #1 ($args) must be of type array, null given
at src/Storage/R2Adapter.php:35
See inline comment [2] for the full explanation.
Member
|
1 minor issue to fix phpcs |
steinkel
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.