Repository navigation
Bundle additional 96px network-device node icons - #313
Merged
TheWitness merged 3 commits intoOct 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation matches the validated assets, existing discovery and packaging support them, and no blocking issues remain.
0 open findings
What changed in this PR
Extends the bundled node-icon library from #304 with seven transparent 96×96 network-device icons and updates the documentation.
Changes:
- Document AP, NAS, server, printer, CCTV recorder, UPS and CCTV camera icons.
- Record the addition in the develop changelog.
| File | Description |
|---|---|
| README.md | Expands bundled-icon documentation to include network devices. |
| CHANGELOG.md | Records the seven new icons under feature #313. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
TheWitness
approved these changes
Oct 17, 2026
TheWitness
pushed a commit
that referenced
this pull request
Oct 17, 2026
* Allow link comments to follow link curves * Use 1000M as the inherited link bandwidth default * Clarify link workflows and add node display-name positioning * Make hover graphs clickable and sharper on high-density displays * Bundle additional 96px network-device node icons * Prepare Weathermap 2.0 identification and release notes * Reference PR #309 in changelog * Reference PR #310 in changelog * Reference PR #311 in changelog * Reference PR #312 in changelog * Reference PR #313 in changelog * Reference PR #314 in changelog * Preserve translation template project metadata * Preserve translation template project metadata * Preserve translation template project metadata * Preserve translation template project metadata * Preserve translation template project metadata * Use established changelog categories throughout 2.0-dev * Preserve Cacti graph layout after Weathermap navigation * Fix traffic glow masking around transparent node icons * Preserve curved comment alignment and nudge direction * Set plugin working directory in bandwidth regression test * Preserve configured hover previews when opening properties * Fix hover density caching and keyboard interaction * Preserve curved glyph kerning and reject reversed offset text * Add the required license notice to bandwidth regression * Preserve traffic identity and hover settings in link properties * Keep mixed-input previews open and protect sharp note text * Parse traffic scaling without ambiguous numeric repetition * Fall back before inward curvature compresses glyph spacing * Honor outer source multipliers and label visible graph pickers * Complete tooltip blur dismissal and keyboard re-entry * Share quarter-circle geometry in rendering regressions * Use the Cacti request helper for the curve checkbox * Resolve Cacti RRA identities and bound editor label presets * Ignore stale tooltip events and quoted zoom text * Add two-step Undo and Redo to the map editor * Use PHP-generated sessions in editor history tests * Isolate duplicated tabs and enforce undo history expiry and quota * Cancel pending hover opens and recognize RRDtool continuations * Import the history worker directly in browser regression tests * Preserve history for unchanged forms and enforce JSON storage quota * Keep undo history when raw configuration dialogs are unchanged * Preserve untouched colour history and validate included restore assets * Gate startup saves and preserve scale order and restored title cache * Cover both graph-picker JSON request signatures in the fixture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add transparent 96×96 PNG node icons: AP, NAS, Server, Printer, CCTV NVR, UPS and CCTV Camera. They are discovered by the existing node-icon library and included by the existing recursive images manifest entry. Update the bundled-icon documentation.
Only the seven final-size PNGs are included; no high-resolution masters or upload artifacts.
Related work
Extends the bundled icon library introduced in #304.
Validation
PHP 8.3 isolated Cacti-layout fixture: 292-test PHP suite; all seven PNGs validated as 96×96 RGBA; manifest check. PHP/JavaScript syntax, whitespace and release manifest checks pass.
Local coverage extensions are unavailable; CI coverage and review results are pending.
Release notes for this change are consolidated in #314 under Weathermap 2.0 (security fixes, issue fixes, then features).