Skip to content

Use 1000M as the inherited link bandwidth default - #310

Merged
TheWitness merged 6 commits into
Cacti:developfrom
alcatron:feat/default-link-bandwidth-20261016
Oct 17, 2026
Merged

TheWitness merged 6 commits into
Cacti:developfrom
alcatron:feat/default-link-bandwidth-20261016

Conversation

@alcatron

@alcatron alcatron commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

Use 1000M for implicit link capacity in both directions, including links in new maps. Explicit BANDWIDTH values remain unchanged.

Compatibility: existing links without an explicit capacity inherit the new default, which changes their calculated utilisation. No user map files are included or rewritten by this PR.

Related work

Part of the planned 2.0 defaults update.

Validation

PHP 8.3 isolated Cacti-layout fixture: 293 tests / 5,902 assertions, including inherited 1000M capacity. PHP/JavaScript syntax, whitespace and release manifest checks pass.

Coverage was not measured in this local run; current CI and review results must be checked separately.

The default-bandwidth regression runs in the plugin working directory and includes the repository copyright/GPL notice.

Release notes for this change are consolidated in #314 under Weathermap 2.0 (security fixes, issue fixes, then features).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new test needs the plugin working directory to avoid plugin-loading warnings under CI.

1 open finding
What changed in this PR

Updates inherited link capacity to 1000M for the planned 2.0 defaults update, without rewriting user maps.

Changes:

  • Raises implicit capacity in both directions while preserving explicit values.
  • Adds regression coverage and a changelog entry.
File Description
tests/​Unit/​DefaultLinkBandwidthTest.php Tests new-map and inherited link capacities.
lib/​WeatherMapLink.class.php Sets numeric and configuration defaults to 1000M.
CHANGELOG.md Documents the default capacity change.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/Unit/DefaultLinkBandwidthTest.php

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow default change has regression coverage, with only a non-blocking test-file license-header correction remaining.

0 open findings

1 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Low severity Add required copyright and GPL v2 license header

tests/​Unit/​DefaultLinkBandwidthTest.php:1

Add the repository-required copyright and GPL v2 license header before the imports, crediting The Cacti Group and Howard Jones. This new PHP file omits the notice used by neighboring engine tests such as tests/Unit/BackgroundSizingEngineTest.php:1–23 and tests/Unit/NewMapPresetEngineTest.php:1–23.

🧠 Review effort: Balanced

@sonarqubecloud

Copy link
Copy Markdown

@alcatron

alcatron commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor Author

Rechecked the current PR and pushed the review repairs. The default-bandwidth regression runs in the plugin working directory and includes the repository copyright/GPL notice.

Validation: 293 tests / 5,902 assertions, plus the focused checks described above. These PR changes have not been installed on the live server. CI results are still separate from local validation.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow default change has focused regression coverage and no unresolved blocking findings.

No open issues 🎉

Review effort: Balanced

@sonarqubecloud

Copy link
Copy Markdown

@TheWitness
TheWitness merged commit 4c2732c into Cacti:develop Oct 17, 2026
2 checks passed
TheWitness pushed a commit that referenced this pull request Oct 17, 2026
* Allow link comments to follow link curves

* Use 1000M as the inherited link bandwidth default

* Clarify link workflows and add node display-name positioning

* Make hover graphs clickable and sharper on high-density displays

* Bundle additional 96px network-device node icons

* Prepare Weathermap 2.0 identification and release notes

* Reference PR #309 in changelog

* Reference PR #310 in changelog

* Reference PR #311 in changelog

* Reference PR #312 in changelog

* Reference PR #313 in changelog

* Reference PR #314 in changelog

* Preserve translation template project metadata

* Preserve translation template project metadata

* Preserve translation template project metadata

* Preserve translation template project metadata

* Preserve translation template project metadata

* Use established changelog categories throughout 2.0-dev

* Preserve Cacti graph layout after Weathermap navigation

* Fix traffic glow masking around transparent node icons

* Preserve curved comment alignment and nudge direction

* Set plugin working directory in bandwidth regression test

* Preserve configured hover previews when opening properties

* Fix hover density caching and keyboard interaction

* Preserve curved glyph kerning and reject reversed offset text

* Add the required license notice to bandwidth regression

* Preserve traffic identity and hover settings in link properties

* Keep mixed-input previews open and protect sharp note text

* Parse traffic scaling without ambiguous numeric repetition

* Fall back before inward curvature compresses glyph spacing

* Honor outer source multipliers and label visible graph pickers

* Complete tooltip blur dismissal and keyboard re-entry

* Share quarter-circle geometry in rendering regressions

* Use the Cacti request helper for the curve checkbox

* Resolve Cacti RRA identities and bound editor label presets

* Ignore stale tooltip events and quoted zoom text

* Add two-step Undo and Redo to the map editor

* Use PHP-generated sessions in editor history tests

* Isolate duplicated tabs and enforce undo history expiry and quota

* Cancel pending hover opens and recognize RRDtool continuations

* Import the history worker directly in browser regression tests

* Preserve history for unchanged forms and enforce JSON storage quota

* Keep undo history when raw configuration dialogs are unchanged

* Preserve untouched colour history and validate included restore assets

* Gate startup saves and preserve scale order and restored title cache

* Cover both graph-picker JSON request signatures in the fixture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants