You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add a searchable node icon picker and bundled site icons - #304
Replace the long node icon dropdown with a searchable preview gallery, readable names and a selected indicator. Preserve the underlying select value for existing save handling and support reopening, no-match feedback and Escape.
Bundle six final 96 px transparent site icons: corporate building, branch office, data centre, warehouse, hospital and clinic. The data centre uses a distinct server-building design, and medical crosses sit above central node labels. Include only the final artwork for these new icons and document the bundle.
Validation: PHP 8.3 tests and all applicable Node/jsdom browser regressions pass in an isolated Cacti fixture. Syntax, whitespace, translation, manifest and changed-line coverage gates pass (100% of measured lines; existing controller/entry-point exemptions apply). The combined changes pass 290 PHP tests (5772 assertions) and 14 browser regressions. These revisions have not been deployed to the live installation.
This is one of five independently based develop PRs in the editor improvement batch. Shared editor files overlap, so later branches may need rebasing after earlier PRs merge.
Escape closes an open icon picker; when it is already closed the key reaches the surrounding node dialog.
Icon picker translation keys use semantic names, consistently shared by PHP, JavaScript and regression tests.
This new user-facing picker and icon bundle has no entry under the develop section of CHANGELOG.md. The repository instructions require all changes to be recorded in CHANGELOG.md or BACKLOG.md; please add a concise feature entry there in addition to this bundle documentation.
This aria-label is applied to a generic div, whose generic role cannot have an accessible name, so assistive technology may not announce “Node icons” for the choice set. Give the container a nameable grouping role so the translated label is exposed.
The reason will be displayed to describe this comment to others. Learn more.
🟢 Approval recommended
The picker preserves save compatibility, includes appropriate accessibility behavior and focused regression coverage, and the bundled images match their documented format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the long node icon dropdown with a searchable preview gallery, readable names and a selected indicator. Preserve the underlying select value for existing save handling and support reopening, no-match feedback and Escape.
Bundle six final 96 px transparent site icons: corporate building, branch office, data centre, warehouse, hospital and clinic. The data centre uses a distinct server-building design, and medical crosses sit above central node labels. Include only the final artwork for these new icons and document the bundle.
Validation: PHP 8.3 tests and all applicable Node/jsdom browser regressions pass in an isolated Cacti fixture. Syntax, whitespace, translation, manifest and changed-line coverage gates pass (100% of measured lines; existing controller/entry-point exemptions apply). The combined changes pass 290 PHP tests (5772 assertions) and 14 browser regressions. These revisions have not been deployed to the live installation.
This is one of five independently based develop PRs in the editor improvement batch. Shared editor files overlap, so later branches may need rebasing after earlier PRs merge.
Escape closes an open icon picker; when it is already closed the key reaches the surrounding node dialog.
Icon picker translation keys use semantic names, consistently shared by PHP, JavaScript and regression tests.