Skip to content

sitetile: the header always paints the page background; header: solid is a real value #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cverorg merged 1 commit into from
Aug 28, 2026
Merged

sitetile: the header always paints the page background; header: solid is a real value #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/sitetile/astro/src/styles/site.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,13 @@ img { max-width: 100%; height: auto; }
display: flex; align-items: center; gap: var(--gd-gap);
padding: 1rem clamp(1rem, 4vw, 3rem);
border-bottom: 1px solid var(--gd-border);
/* A header has a floor: the page background. Without it a sticky header lets the page scroll
through it (measured on a built site: computed background rgba(0,0,0,0) while sticky).
`header: translucent` below still layers its 86% + blur on top; `header: solid` is now a
real, explicit value that means exactly this floor. */
background: var(--gd-bg);
}
body[data-header="solid"] .rf-header { background: var(--gd-bg); }
.rf-logo { font-weight: 700; font-size: 1.125rem; color: var(--gd-text); text-decoration: none; }
.rf-nav { display: flex; gap: 1.25rem; }
.rf-nav a { color: var(--gd-muted); text-decoration: none; }
Expand Down
8 changes: 8 additions & 0 deletions packages/sitetile/section-inset.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,3 +258,11 @@ test('🩸 CONTROL: the inline-span rule stays scoped to span, so it can never r
});

console.log(` ${passed} passed`);

// A sticky header must not let the page scroll through it: the base .rf-header carries the page
// background, and `header: solid` names that floor explicitly (2026-08-28).
{
const base = CSS.match(/\.rf-header \{[^}]*\}/);
assert.ok(base && /background:\s*var\(--gd-bg\)/.test(base[0]), '.rf-header base rule paints the page background');
assert.ok(/body\[data-header="solid"\] \.rf-header \{[^}]*background:\s*var\(--gd-bg\)/.test(CSS), 'header: solid is a real treatment value');
}
Loading